From: Richard Zhu <hongxing.zhu@nxp.com>
To: Lucas Stach <l.stach@pengutronix.de>,
"andrew.smirnov@gmail.com" <andrew.smirnov@gmail.com>,
"shawnguo@kernel.org" <shawnguo@kernel.org>,
"kw@linux.com" <kw@linux.com>,
"bhelgaas@google.com" <bhelgaas@google.com>,
"stefan@agner.ch" <stefan@agner.ch>,
"lorenzo.pieralisi@arm.com" <lorenzo.pieralisi@arm.com>
Cc: "linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
dl-linux-imx <linux-imx@nxp.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"kernel@pengutronix.de" <kernel@pengutronix.de>
Subject: RE: Re: [PATCH 1/3] dt-bindings: imx6q-pcie: specify the imx8mq pcie phy voltage
Date: Mon, 22 Mar 2021 09:06:30 +0000 [thread overview]
Message-ID: <VI1PR04MB585364FC420972C538281F2B8C659@VI1PR04MB5853.eurprd04.prod.outlook.com> (raw)
> -----Original Message-----
> From: Lucas Stach <l.stach@pengutronix.de>
> Sent: Friday, March 19, 2021 5:49 PM
> To: Richard Zhu <hongxing.zhu@nxp.com>; andrew.smirnov@gmail.com;
> shawnguo@kernel.org; kw@linux.com; bhelgaas@google.com;
> stefan@agner.ch; lorenzo.pieralisi@arm.com
> Cc: linux-pci@vger.kernel.org; dl-linux-imx <linux-imx@nxp.com>;
> linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org;
> kernel@pengutronix.de
> Subject: [EXT] Re: [PATCH 1/3] dt-bindings: imx6q-pcie: specify the imx8mq
> pcie phy voltage
> Am Freitag, dem 19.03.2021 um 16:24 +0800 schrieb Richard Zhu:
> > Both 1.8v and 3.3v power supplies can be feeded to i.MX8MQ PCIe PHY.
> > In default, the PCIE_VPH voltage is suggested to be 1.8v refer to data
> > sheet. When PCIE_VPH is supplied by 3.3v in the HW schematic design,
> > the VREG_BYPASS bits of GPR registers should be cleared from default
> > value 1b'1 to 1b'0.
> >
> > Signed-off-by: Richard Zhu <hongxing.zhu@nxp.com>
> > ---
> > Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt
> > b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt
> > index de4b2baf91e8..23efbad9e804 100644
> > --- a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt
> > +++ b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt
> > @@ -59,6 +59,10 @@ Additional required properties for imx7d-pcie and
> imx8mq-pcie:
> > Additional required properties for imx8mq-pcie:
> > - clock-names: Must include the following additional entries:
> > - "pcie_aux"
> > +- pcie-vph-3v3: If present then PCIE_VPH is feeded by 3.3v in the HW
> > + schematic design. The PCIE_VPH is suggested to be 1.8v refer to the
> > + data sheet. If the PCIE_VPH is supplied by 3.3V, the VREG_BYPASS
> > + should be cleared to zero accordingly.
>
> Uhm, no. Please don't add boolean DT properties for random parts of the
> board design.
>
> If we need to know the voltage of PCIE_VPH, we should really add the VPH
> regulator as a supply to the PCIe controller node, then work out the voltage
> the usual way by using the Linux regulator API.
>
[Richard Zhu] Hi Lucas:
Thanks for your comments. Since the vgen5_reg is used to power up PCIe PHY on i.MX8MQ EVK board,
and it's set to be "regulator-always-on;".
Did only the regulator_get_voltage or combined with regulator_enable/regulator_disable can be used in the driver?
Best Regards
Richard Zhu
> Regards,
> Lucas
next reply other threads:[~2021-03-22 9:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-22 9:06 Richard Zhu [this message]
2021-03-22 12:14 ` Re: [PATCH 1/3] dt-bindings: imx6q-pcie: specify the imx8mq pcie phy voltage Lucas Stach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=VI1PR04MB585364FC420972C538281F2B8C659@VI1PR04MB5853.eurprd04.prod.outlook.com \
--to=hongxing.zhu@nxp.com \
--cc=andrew.smirnov@gmail.com \
--cc=bhelgaas@google.com \
--cc=kernel@pengutronix.de \
--cc=kw@linux.com \
--cc=l.stach@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=shawnguo@kernel.org \
--cc=stefan@agner.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).