From: Bernd Edlinger <bernd.edlinger@hotmail.de>
To: Theodore Ts'o <tytso@mit.edu>, Arnd Bergmann <arnd@arndb.de>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] random: Make /dev/random wait for crng_ready
Date: Fri, 15 Feb 2019 05:40:51 +0000 [thread overview]
Message-ID: <VI1PR0702MB384026744E79BE0E82EABBDEE4600@VI1PR0702MB3840.eurprd07.prod.outlook.com> (raw)
In-Reply-To: <VI1PR0702MB38408B595C818F1C3278873EE4600@VI1PR0702MB3840.eurprd07.prod.outlook.com>
On 2/15/19 2:47 AM, Bernd Edlinger wrote:
> while (1) {
> - n = extract_entropy_user(&blocking_pool, buf, nbytes);
> + n = crng_ready()
> + ? extract_entropy_user(&blocking_pool, buf, nbytes)
> + : 0;
Aehm, the whitespace after ? does not align with :, didn't see that before.
I wonder if it would be better style to use
if (crng_ready())
n = extract...;
else
n = 0;
Bernd.
next prev parent reply other threads:[~2019-02-15 5:40 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-15 1:47 [PATCH] random: Make /dev/random wait for crng_ready Bernd Edlinger
2019-02-15 5:40 ` Bernd Edlinger [this message]
2019-02-15 13:58 ` [PATCHv2] " Bernd Edlinger
2019-02-16 18:23 ` Theodore Y. Ts'o
2019-02-16 20:12 ` Bernd Edlinger
2019-02-17 8:44 ` [PATCHv3] " Bernd Edlinger
2019-02-17 13:48 ` Bernd Edlinger
2019-02-17 20:55 ` [PATCHv4] random: Make /dev/random wait for input_pool initialized Bernd Edlinger
2019-02-19 7:16 ` Bernd Edlinger
2019-02-19 17:09 ` [PATCHv5] " Bernd Edlinger
2019-02-21 0:32 ` [PATCHv5] random: Make /dev/random wait for input_pool initializedy Theodore Y. Ts'o
2019-02-21 19:24 ` Bernd Edlinger
2019-02-21 23:18 ` Theodore Y. Ts'o
2019-02-22 13:45 ` Bernd Edlinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=VI1PR0702MB384026744E79BE0E82EABBDEE4600@VI1PR0702MB3840.eurprd07.prod.outlook.com \
--to=bernd.edlinger@hotmail.de \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).