From: Steve Twiss <stwiss.opensource@diasemi.com>
To: "Gustavo A. R. Silva" <gustavo@embeddedor.com>,
Support Opensource <Support.Opensource@diasemi.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] regulator: da9062: Use struct_size() in devm_kzalloc()
Date: Mon, 25 Feb 2019 13:13:30 +0000 [thread overview]
Message-ID: <VI1PR10MB2352218825B8BFC3D4F6C6D8FE7A0@VI1PR10MB2352.EURPRD10.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <20190223015451.GA24619@embeddedor>
Hi Gustavo,
On 23 February 2019 01:55, Gustavo A. R. Silva wrote:
> Subject: [PATCH] regulator: da9062: Use struct_size() in devm_kzalloc()
>
> One of the more common cases of allocation size calculations is finding
> the size of a structure that has a zero-sized array at the end, along
> with memory for some number of elements for that array. For example:
>
> struct foo {
> int stuff;
> struct boo entry[];
> };
>
> size = sizeof(struct foo) + count * sizeof(struct boo);
> instance = alloc(size, GFP_KERNEL)
>
> Instead of leaving these open-coded and prone to type mistakes, we can
> now use the new struct_size() helper:
Acked-by: Steve Twiss <stwiss.opensource@diasemi.com>
Thanks,
Regards,
Steve
>
> instance = alloc(struct_size(instance, entry, count), GFP_KERNEL)
>
> Notice that, in this case, variable size is not necessary, hence it is
> removed.
>
> This code was detected with the help of Coccinelle.
>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> ---
> drivers/regulator/da9062-regulator.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/regulator/da9062-regulator.c b/drivers/regulator/da9062-
> regulator.c
> index 4c5d6ad853f8..b064d8a19d4c 100644
> --- a/drivers/regulator/da9062-regulator.c
> +++ b/drivers/regulator/da9062-regulator.c
> @@ -992,7 +992,6 @@ static int da9062_regulator_probe(struct platform_device
> *pdev)
> struct regulator_config config = { };
> const struct da9062_regulator_info *rinfo;
> int irq, n, ret;
> - size_t size;
> int max_regulators;
>
> switch (chip->chip_type) {
> @@ -1010,9 +1009,8 @@ static int da9062_regulator_probe(struct
> platform_device *pdev)
> }
>
> /* Allocate memory required by usable regulators */
> - size = sizeof(struct da9062_regulators) +
> - max_regulators * sizeof(struct da9062_regulator);
> - regulators = devm_kzalloc(&pdev->dev, size, GFP_KERNEL);
> + regulators = devm_kzalloc(&pdev->dev, struct_size(regulators, regulator,
> + max_regulators), GFP_KERNEL);
> if (!regulators)
> return -ENOMEM;
>
> --
> 2.20.1
prev parent reply other threads:[~2019-02-25 13:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-23 1:54 [PATCH] regulator: da9062: Use struct_size() in devm_kzalloc() Gustavo A. R. Silva
2019-02-25 13:13 ` Steve Twiss [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=VI1PR10MB2352218825B8BFC3D4F6C6D8FE7A0@VI1PR10MB2352.EURPRD10.PROD.OUTLOOK.COM \
--to=stwiss.opensource@diasemi.com \
--cc=Support.Opensource@diasemi.com \
--cc=broonie@kernel.org \
--cc=gustavo@embeddedor.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).