* [PATCH] platform/x86: pmc_atom: Add Siemens CONNECT X300 to critclk_systems DMI table
@ 2019-11-29 9:16 Michael Haener
2019-11-29 10:15 ` Andy Shevchenko
0 siblings, 1 reply; 3+ messages in thread
From: Michael Haener @ 2019-11-29 9:16 UTC (permalink / raw)
To: andy; +Cc: Michael Haener, Darren Hart, platform-driver-x86, linux-kernel
The CONNECT X300 uses the PMC clock for on-board components and gets
stuck during boot if the clock is disabled. Therefore, add this
device to the critical systems list.
Tested on CONNECT X300.
Fixes: 648e921888ad ("clk: x86: Stop marking clocks as CLK_IS_CRITICAL")
Signed-off-by: Michael Haener <michael.haener@siemens.com>
---
drivers/platform/x86/pmc_atom.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/drivers/platform/x86/pmc_atom.c b/drivers/platform/x86/pmc_atom.c
index 07d1b911e72f..57f06ca114a6 100644
--- a/drivers/platform/x86/pmc_atom.c
+++ b/drivers/platform/x86/pmc_atom.c
@@ -429,6 +429,14 @@ static const struct dmi_system_id critclk_systems[] = {
DMI_MATCH(DMI_PRODUCT_VERSION, "6AV7882-0"),
},
},
+ {
+ .ident = "CONNECT X300",
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "SIEMENS AG"),
+ DMI_MATCH(DMI_PRODUCT_VERSION, "A5E45074588")
+ },
+ },
+
{ /*sentinel*/ }
};
--
2.11.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] platform/x86: pmc_atom: Add Siemens CONNECT X300 to critclk_systems DMI table
2019-11-29 9:16 [PATCH] platform/x86: pmc_atom: Add Siemens CONNECT X300 to critclk_systems DMI table Michael Haener
@ 2019-11-29 10:15 ` Andy Shevchenko
2019-11-30 6:41 ` Haener, Michael
0 siblings, 1 reply; 3+ messages in thread
From: Andy Shevchenko @ 2019-11-29 10:15 UTC (permalink / raw)
To: Michael Haener
Cc: Andy Shevchenko, Darren Hart, Platform Driver, Linux Kernel Mailing List
On Fri, Nov 29, 2019 at 11:19 AM Michael Haener
<michael.haener@siemens.com> wrote:
>
> The CONNECT X300 uses the PMC clock for on-board components and gets
> stuck during boot if the clock is disabled. Therefore, add this
> device to the critical systems list.
> Tested on CONNECT X300.
Thank you for your patch!
Can you be more specific about the clock (which one? For example plt2)
and if possible type of hardware IP which is connected to it (for
example, Realtek Ethernet)?
> Fixes: 648e921888ad ("clk: x86: Stop marking clocks as CLK_IS_CRITICAL")
> Signed-off-by: Michael Haener <michael.haener@siemens.com>
> ---
> drivers/platform/x86/pmc_atom.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/drivers/platform/x86/pmc_atom.c b/drivers/platform/x86/pmc_atom.c
> index 07d1b911e72f..57f06ca114a6 100644
> --- a/drivers/platform/x86/pmc_atom.c
> +++ b/drivers/platform/x86/pmc_atom.c
> @@ -429,6 +429,14 @@ static const struct dmi_system_id critclk_systems[] = {
> DMI_MATCH(DMI_PRODUCT_VERSION, "6AV7882-0"),
> },
> },
> + {
> + .ident = "CONNECT X300",
> + .matches = {
> + DMI_MATCH(DMI_SYS_VENDOR, "SIEMENS AG"),
> + DMI_MATCH(DMI_PRODUCT_VERSION, "A5E45074588")
> + },
> + },
> +
> { /*sentinel*/ }
> };
>
> --
> 2.11.0
>
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [PATCH] platform/x86: pmc_atom: Add Siemens CONNECT X300 to critclk_systems DMI table
2019-11-29 10:15 ` Andy Shevchenko
@ 2019-11-30 6:41 ` Haener, Michael
0 siblings, 0 replies; 3+ messages in thread
From: Haener, Michael @ 2019-11-30 6:41 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Andy Shevchenko, Darren Hart, Platform Driver, Linux Kernel Mailing List
> From: Andy Shevchenko <andy.shevchenko@gmail.com>
> Sent: Freitag, 29. November 2019 11:16
> To: Häner, Michael (SI BP R&D ZG FW CCP) <michael.haener@siemens.com>
> Cc: Andy Shevchenko <andy@infradead.org>; Darren Hart
> <dvhart@infradead.org>; Platform Driver <platform-driver-
> x86@vger.kernel.org>; Linux Kernel Mailing List <linux-
> kernel@vger.kernel.org>
> Subject: Re: [PATCH] platform/x86: pmc_atom: Add Siemens CONNECT X300
> to critclk_systems DMI table
>
> On Fri, Nov 29, 2019 at 11:19 AM Michael Haener
> <michael.haener@siemens.com> wrote:
> >
> > The CONNECT X300 uses the PMC clock for on-board components and gets
> > stuck during boot if the clock is disabled. Therefore, add this
> > device to the critical systems list.
> > Tested on CONNECT X300.
>
> Thank you for your patch!
> Can you be more specific about the clock (which one? For example plt2)
> and if possible type of hardware IP which is connected to it (for
> example, Realtek Ethernet)?
I'm sorry, I don't have more detailed information. I only identified the bug
by git bisect.
>
> > Fixes: 648e921888ad ("clk: x86: Stop marking clocks as CLK_IS_CRITICAL")
> > Signed-off-by: Michael Haener <michael.haener@siemens.com>
> > ---
> > drivers/platform/x86/pmc_atom.c | 8 ++++++++
> > 1 file changed, 8 insertions(+)
> >
> > diff --git a/drivers/platform/x86/pmc_atom.c
> b/drivers/platform/x86/pmc_atom.c
> > index 07d1b911e72f..57f06ca114a6 100644
> > --- a/drivers/platform/x86/pmc_atom.c
> > +++ b/drivers/platform/x86/pmc_atom.c
> > @@ -429,6 +429,14 @@ static const struct dmi_system_id critclk_systems[]
> = {
> > DMI_MATCH(DMI_PRODUCT_VERSION, "6AV7882-0"),
> > },
> > },
> > + {
> > + .ident = "CONNECT X300",
> > + .matches = {
> > + DMI_MATCH(DMI_SYS_VENDOR, "SIEMENS AG"),
> > + DMI_MATCH(DMI_PRODUCT_VERSION, "A5E45074588")
> > + },
> > + },
> > +
> > { /*sentinel*/ }
> > };
> >
> > --
> > 2.11.0
> >
>
>
> --
> With Best Regards,
> Andy Shevchenko
With Best Regards,
Michael Haener
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-11-30 6:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-29 9:16 [PATCH] platform/x86: pmc_atom: Add Siemens CONNECT X300 to critclk_systems DMI table Michael Haener
2019-11-29 10:15 ` Andy Shevchenko
2019-11-30 6:41 ` Haener, Michael
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).