Re: [PATCH 1/5] dt-bindings: rtc: Rework compatible strings and add #clock-cells

[Paul Cercueil <paul@crapouillou.net>]

Hi Krzysztof,

Le mar., avril 19 2022 at 08:41:56 +0200, Krzysztof Kozlowski 
<krzysztof.kozlowski@linaro.org> a écrit :
> On 18/04/2022 20:49, Paul Cercueil wrote:
>>  The RTC in the JZ4770 is compatible with the JZ4760, but has an 
>> extra
>>  register that permits to configure the behaviour of the CLK32K pin. 
>> The
>>  same goes for the RTC in the JZ4780.
>> 
>>  Therefore, the ingenic,jz4770-rtc and ingenic,jz4780-rtc strings do 
>> not
>>  fall back anymore to ingenic,jz4760-rtc. The ingenic,jz4780-rtc 
>> string
>>  now falls back to the ingenic,jz4770-rtc string.
>> 
>>  Additionally, since the RTCs in the JZ4770 and JZ4780 support 
>> outputting
>>  the input oscillator's clock to the CLK32K pin, the RTC node is now 
>> also
>>  a clock provider on these SoCs, so a #clock-cells property is added.
>> 
>>  Signed-off-by: Paul Cercueil <paul@crapouillou.net>
>>  Cc: Rob Herring <robh+dt@kernel.org>
>>  Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
>>  ---
>>   Documentation/devicetree/bindings/rtc/ingenic,rtc.yaml | 7 +++++--
>>   1 file changed, 5 insertions(+), 2 deletions(-)
>> 
>>  diff --git a/Documentation/devicetree/bindings/rtc/ingenic,rtc.yaml 
>> b/Documentation/devicetree/bindings/rtc/ingenic,rtc.yaml
>>  index b235b2441997..57393c3ac724 100644
>>  --- a/Documentation/devicetree/bindings/rtc/ingenic,rtc.yaml
>>  +++ b/Documentation/devicetree/bindings/rtc/ingenic,rtc.yaml
>>  @@ -18,14 +18,14 @@ properties:
>>         - enum:
>>             - ingenic,jz4740-rtc
>>             - ingenic,jz4760-rtc
>>  +          - ingenic,jz4770-rtc
>>         - items:
>>             - const: ingenic,jz4725b-rtc
>>             - const: ingenic,jz4740-rtc
>>         - items:
>>             - enum:
>>  -              - ingenic,jz4770-rtc
>>                 - ingenic,jz4780-rtc
>>  -          - const: ingenic,jz4760-rtc
>>  +          - const: ingenic,jz4770-rtc
>> 
>>     reg:
>>       maxItems: 1
>>  @@ -39,6 +39,9 @@ properties:
>>     clock-names:
>>       const: rtc
>> 
>>  +  "#clock-cells":
>>  +    const: 0
>>  +
>>     system-power-controller:
>>       description: |
>>         Indicates that the RTC is responsible for powering OFF
> 
> Inside allOf:if:then:, please add a constraint which compatible cannot
> have clock-cells (or maybe better which can?).
> 
> Some modification of:
> https://elixir.bootlin.com/linux/v5.17-rc2/source/Documentation/devicetree/bindings/media/renesas,vsp1.yaml#L53

Sure.

Cheers,
-Paul