From: "Theodore Ts'o" <tytso@mit.edu>
To: Daejun Park <daejun7.park@samsung.com>
Cc: "adilger.kernel@dilger.ca" <adilger.kernel@dilger.ca>,
"harshadshirwadkar@gmail.com" <harshadshirwadkar@gmail.com>,
"linux-ext4@vger.kernel.org" <linux-ext4@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ext4: Remove expensive flush on fast commit
Date: Wed, 13 Jan 2021 22:44:57 -0500 [thread overview]
Message-ID: <X/++OfdtJSykRIeB@mit.edu> (raw)
In-Reply-To: <20210106013242epcms2p5b6b4ed8ca86f29456fdf56aa580e74b4@epcms2p5>
On Wed, Jan 06, 2021 at 10:32:42AM +0900, Daejun Park wrote:
> In the fast commit, it adds REQ_FUA and REQ_PREFLUSH on each fast commit
> block when barrier is enabled. However, in recovery phase, ext4 compares
> CRC value in the tail. So it is sufficient adds REQ_FUA and REQ_PREFLUSH
> on the block that has tail.
>
> Signed-off-by: Daejun Park <daejun7.park@samsung.com>
Thanks, applied.
- Ted
prev parent reply other threads:[~2021-01-14 3:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20210106013242epcms2p5b6b4ed8ca86f29456fdf56aa580e74b4@epcms2p5>
2021-01-06 1:32 ` [PATCH] ext4: Remove expensive flush on fast commit Daejun Park
2021-01-06 21:58 ` harshad shirwadkar
2021-01-08 2:26 ` Andreas Dilger
[not found] ` <CGME20210106013242epcms2p5b6b4ed8ca86f29456fdf56aa580e74b4@epcms2p3>
2021-01-08 2:37 ` Daejun Park
2021-01-06 22:05 ` Darrick J. Wong
2021-01-14 3:44 ` Theodore Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=X/++OfdtJSykRIeB@mit.edu \
--to=tytso@mit.edu \
--cc=adilger.kernel@dilger.ca \
--cc=daejun7.park@samsung.com \
--cc=harshadshirwadkar@gmail.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).