From: "Ahmed S. Darwish" <a.darwish@linutronix.de>
To: John Garry <john.garry@huawei.com>
Cc: jejb@linux.ibm.com, martin.petersen@oracle.com,
artur.paszkiewicz@intel.com, jinpu.wang@cloud.ionos.com,
corbet@lwn.net, yanaijie@huawei.com, bigeasy@linutronix.de,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
intel-linux-scu@intel.com, linux-doc@vger.kernel.org
Subject: Re: [PATCH] scsi: libsas and users: Remove notifier indirection
Date: Tue, 12 Jan 2021 12:25:01 +0100 [thread overview]
Message-ID: <X/2HDUmb8L8LPELG@lx-t490> (raw)
In-Reply-To: <1610386112-132641-1-git-send-email-john.garry@huawei.com>
Hi John,
On Tue, Jan 12, 2021 at 01:28:32AM +0800, John Garry wrote:
> LLDDs report events to libsas with .notify_port_event and
> .notify_phy_event callbacks.
>
> These callbacks are fixed and so there is no reason why the functions
> cannot be called directly, so do that.
>
> This neatens the code slightly, makes it more obvious, and reduces
> function pointer usage, which is generally a good thing. Downside is that
> there are 2x more symbol exports.
>
> Signed-off-by: John Garry <john.garry@huawei.com>
>
Since this patch necessitates a careful manual rebase of _every_ patch
in my series, I've included it at the top of my v2 submission and
rebased everything on top:
https://lkml.kernel.org/r/20210112110647.627783-1-a.darwish@linutronix.de
Some left-over 'sas_ha' local variables were removed, and I've mentioned
that in the commit log of course.
Thanks!
--
Ahmed S. Darwish
Linutronix GmbH
next prev parent reply other threads:[~2021-01-12 11:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-11 17:28 [PATCH] scsi: libsas and users: Remove notifier indirection John Garry
2021-01-11 17:41 ` Ahmed S. Darwish
2021-01-11 17:44 ` John Garry
2021-01-11 17:52 ` Ahmed S. Darwish
2021-01-11 19:49 ` kernel test robot
2021-01-12 11:25 ` Ahmed S. Darwish [this message]
2021-01-12 11:27 ` John Garry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=X/2HDUmb8L8LPELG@lx-t490 \
--to=a.darwish@linutronix.de \
--cc=artur.paszkiewicz@intel.com \
--cc=bigeasy@linutronix.de \
--cc=corbet@lwn.net \
--cc=intel-linux-scu@intel.com \
--cc=jejb@linux.ibm.com \
--cc=jinpu.wang@cloud.ionos.com \
--cc=john.garry@huawei.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=yanaijie@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).