From: Greg KH <greg@kroah.com>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: "David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Hayes Wang <hayeswang@realtek.com>,
Marek Szyprowski <m.szyprowski@samsung.com>,
linux-usb@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] nt: usb: USB_RTL8153_ECM should not default to y
Date: Wed, 13 Jan 2021 17:00:09 +0100 [thread overview]
Message-ID: <X/8ZCa/jgiAboGd7@kroah.com> (raw)
In-Reply-To: <20210113144309.1384615-1-geert+renesas@glider.be>
On Wed, Jan 13, 2021 at 03:43:09PM +0100, Geert Uytterhoeven wrote:
> In general, device drivers should not be enabled by default.
>
> Fixes: 657bc1d10bfc23ac ("r8153_ecm: avoid to be prior to r8152 driver")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> drivers/net/usb/Kconfig | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/usb/Kconfig b/drivers/net/usb/Kconfig
> index 1e37190287808973..fbbe786436319013 100644
> --- a/drivers/net/usb/Kconfig
> +++ b/drivers/net/usb/Kconfig
> @@ -631,7 +631,6 @@ config USB_NET_AQC111
> config USB_RTL8153_ECM
> tristate "RTL8153 ECM support"
> depends on USB_NET_CDCETHER && (USB_RTL8152 || USB_RTL8152=n)
> - default y
> help
> This option supports ECM mode for RTL8153 ethernet adapter, when
> CONFIG_USB_RTL8152 is not set, or the RTL8153 device is not
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
next prev parent reply other threads:[~2021-01-13 16:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-13 14:43 [PATCH] nt: usb: USB_RTL8153_ECM should not default to y Geert Uytterhoeven
2021-01-13 16:00 ` Greg KH [this message]
2021-01-14 19:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=X/8ZCa/jgiAboGd7@kroah.com \
--to=greg@kroah.com \
--cc=davem@davemloft.net \
--cc=geert+renesas@glider.be \
--cc=hayeswang@realtek.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).