From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7919C433E0 for ; Sun, 3 Jan 2021 17:00:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7A9AD2151B for ; Sun, 3 Jan 2021 17:00:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727693AbhACRAo (ORCPT ); Sun, 3 Jan 2021 12:00:44 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:47586 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727281AbhACRAn (ORCPT ); Sun, 3 Jan 2021 12:00:43 -0500 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1kw6jT-00Fo9w-F3; Sun, 03 Jan 2021 17:59:55 +0100 Date: Sun, 3 Jan 2021 17:59:55 +0100 From: Andrew Lunn To: Rob Herring Cc: Robert Marko , agross@kernel.org, bjorn.andersson@linaro.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org, linux@armlinux.org.uk, Luka Perkov Subject: Re: [PATCH 2/4] dt-bindings: net: Add bindings for Qualcomm QCA807x Message-ID: References: <20201222222637.3204929-1-robert.marko@sartura.hr> <20201222222637.3204929-3-robert.marko@sartura.hr> <20201223005633.GR3107610@lunn.ch> <20210103164613.GA4012977@robh.at.kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210103164613.GA4012977@robh.at.kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > > + qcom,tx-driver-strength: > > > + description: PSGMII/QSGMII TX driver strength control. > > > + $ref: /schemas/types.yaml#/definitions/uint32 > > > + enum: [0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12] > > > > Please use the actual values here, and have the driver convert to the > > value poked into the register. So the property would be > > qcom,tx-driver-strength-mv and it would have the value 220 for > > example. > > The LED binding has properties for specifying the current already. And > it's max current which is the h/w property where as anything less is > just software configuration (IOW, doesn't belong in DT). Hi Rob My understanding of this is it is the drive strength of the SERDES line. Nothing to do with LEDs. The description needs improving. Andrew