From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D45EFC433E0 for ; Tue, 5 Jan 2021 18:11:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A12AC22D6D for ; Tue, 5 Jan 2021 18:11:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728623AbhAESLN (ORCPT ); Tue, 5 Jan 2021 13:11:13 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35328 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727830AbhAESLM (ORCPT ); Tue, 5 Jan 2021 13:11:12 -0500 Received: from mail-ot1-x32a.google.com (mail-ot1-x32a.google.com [IPv6:2607:f8b0:4864:20::32a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 15A12C061798 for ; Tue, 5 Jan 2021 10:10:18 -0800 (PST) Received: by mail-ot1-x32a.google.com with SMTP id w3so493356otp.13 for ; Tue, 05 Jan 2021 10:10:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=ChxLExLWVt+4oIqEbZryBNyc23+uw95BAKSDa6CCwHY=; b=g03PUSF1AQTEeEna9/1Fsd6hp+l7cmEBGnOoeFWIQDU5z0w2879vusNpE5UcSPG0Fp TUmIUjRNHbBay3NSfQDI56m57kN3ae9Z4cr7q2zU1tCNTPfOVher0HuVgxi130qiTJoh PpWwzCMWWa2VUT2/SEzU7EUUlowMVIKbdSTbOCPIFDOcFVxMizd/U7sBhmSfVGkmpwqR fUGHw+/sqfAfUuGIPA93tm2gTgP9DP4xn5opDtbcgFL+NCUWo2xDtV/SPE4S80EpqV0D s7FZrFgqZbepwBKhygbmRMn901XL6zRtg+sK289K94jcV0l7f9ErC/7sSkVHvBtBQYIf irRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ChxLExLWVt+4oIqEbZryBNyc23+uw95BAKSDa6CCwHY=; b=dZjBI1Yd5qEEBz//xOt6KU3SoGrLLd8/6UevdcDIRt+HAuBzKm6T5Sz/L256EFzyR7 iQoSE734UqC0uha+kh5RDl/GUkCJ2aiZmrjdzeEn8zAFwsHTaP9E0wYYCznKZPhwrw/R UCy79RLDEZmTz96w6o/enzxJ+/o2R8B/z2w1bNhJyZs0GZ1V6f/o5PbIxzU3B6iSzNro 5GmBtg+xih7Cw5hHq8dFzbP0QX4IgOAMZNiUxA0F7BmO58Drq00S5rxTW30z6AF/zGLl u8Fwz04jSdTQIkKJeDUzNN0U0dwXFHBTIms6GKNZOi8bimQUmN4ZkNqiemb5NYyKvECW L27w== X-Gm-Message-State: AOAM530aB3MoNHTxa8YLyyGXYiIYrzPcLksg7/Y44jidxT+oVT0WggLn +0yg/gCj6bAyO9rpJedONmU9qA== X-Google-Smtp-Source: ABdhPJxnpf1w3cbKdhVS26iYtgVJ5hjsdFUs0TVCcQlAxhGj3Yd2RskFmZUjPVUBd3DQdlTk37dEXg== X-Received: by 2002:a05:6830:118b:: with SMTP id u11mr543336otq.130.1609870218397; Tue, 05 Jan 2021 10:10:18 -0800 (PST) Received: from builder.lan (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id j126sm33949oib.13.2021.01.05.10.10.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Jan 2021 10:10:17 -0800 (PST) Date: Tue, 5 Jan 2021 12:10:15 -0600 From: Bjorn Andersson To: Manivannan Sadhasivam Cc: agross@kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Vinod Koul Subject: Re: [PATCH v2 17/18] ARM: dts: qcom: Add PMIC pmx55 dts Message-ID: References: <20210105122649.13581-1-manivannan.sadhasivam@linaro.org> <20210105122649.13581-18-manivannan.sadhasivam@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210105122649.13581-18-manivannan.sadhasivam@linaro.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue 05 Jan 06:26 CST 2021, Manivannan Sadhasivam wrote: > From: Vinod Koul > > This adds DTS for PMIC PMX55 found in Qualcomm platforms. > > Signed-off-by: Vinod Koul > Signed-off-by: Manivannan Sadhasivam > --- > arch/arm/boot/dts/qcom-pmx55.dtsi | 91 +++++++++++++++++++++++++++++++ > 1 file changed, 91 insertions(+) > create mode 100644 arch/arm/boot/dts/qcom-pmx55.dtsi > > diff --git a/arch/arm/boot/dts/qcom-pmx55.dtsi b/arch/arm/boot/dts/qcom-pmx55.dtsi > new file mode 100644 > index 000000000000..05f033334716 > --- /dev/null > +++ b/arch/arm/boot/dts/qcom-pmx55.dtsi > @@ -0,0 +1,91 @@ > +// SPDX-License-Identifier: BSD-3-Clause > + > +/* > + * Copyright (c) 2018-2020, The Linux Foundation. All rights reserved. > + * Copyright (c) 2020, Linaro Limited > + */ > + > +#include > +#include > +#include > + > +&spmi_bus { > + pmic@8 { > + compatible = "qcom,pmx55", "qcom,spmi-pmic"; > + reg = <0x8 SPMI_USID>; > + #address-cells = <1>; > + #size-cells = <0>; > + > + power-on@800 { > + compatible = "qcom,pm8916-pon"; > + reg = <0x0800>; > + > + status = "disabled"; > + }; > + > + pmx55_temp: temp-alarm@2400 { > + compatible = "qcom,spmi-temp-alarm"; > + reg = <0x2400>; > + interrupts = <0x8 0x24 0x0 IRQ_TYPE_EDGE_BOTH>; > + io-channels = <&pmx55_adc ADC5_DIE_TEMP>; > + io-channel-names = "thermal"; > + #thermal-sensor-cells = <0>; > + }; > + > + pmx55_adc: adc@3100 { > + compatible = "qcom,spmi-adc5"; > + reg = <0x3100>; > + #address-cells = <1>; > + #size-cells = <0>; > + #io-channel-cells = <1>; > + interrupts = <0x8 0x31 0x0 IRQ_TYPE_EDGE_RISING>; > + > + ref-gnd@0 { > + reg = ; > + qcom,pre-scaling = <1 1>; > + label = "ref_gnd"; > + }; > + > + vref-1p25@1 { > + reg = ; > + qcom,pre-scaling = <1 1>; > + label = "vref_1p25"; > + }; > + > + die-temp@6 { > + reg = ; > + qcom,pre-scaling = <1 1>; > + label = "die_temp"; > + }; > + > + chg-temp@9 { > + reg = ; > + qcom,pre-scaling = <1 1>; > + label = "chg_temp"; > + }; > + }; > + > + pmx55_gpios: gpio@c000 { > + compatible = "qcom,pmx55-gpio", "qcom,spmi-gpio"; > + reg = <0xc000>; > + gpio-controller; > + #gpio-cells = <2>; > + interrupt-controller; > + #interrupt-cells = <2>; > + interrupts = <0x8 0xc0 0x0 IRQ_TYPE_NONE>, > + <0x8 0xc1 0x0 IRQ_TYPE_NONE>, > + <0x8 0xc3 0x0 IRQ_TYPE_NONE>, > + <0x8 0xc4 0x0 IRQ_TYPE_NONE>, > + <0x8 0xc5 0x0 IRQ_TYPE_NONE>, > + <0x8 0xc7 0x0 IRQ_TYPE_NONE>, > + <0x8 0xc8 0x0 IRQ_TYPE_NONE>; Brian reworked the spmi-gpio driver a while back to use hierarchical irqdomains instead of this, so please drop the "interrupts" property. For reference see e.g.: f14a5e6da4a5 ("arm64: dts: qcom: pmi8998: add interrupt controller properties") Regards, Bjorn > + }; > + }; > + > + pmic@9 { > + compatible = "qcom,pmx55", "qcom,spmi-pmic"; > + reg = <0x9 SPMI_USID>; > + #address-cells = <1>; > + #size-cells = <0>; > + }; > +}; > -- > 2.25.1 >