From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF3CEC433E9 for ; Wed, 6 Jan 2021 10:37:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A13272310E for ; Wed, 6 Jan 2021 10:37:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726919AbhAFKgx (ORCPT ); Wed, 6 Jan 2021 05:36:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48948 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726862AbhAFKgx (ORCPT ); Wed, 6 Jan 2021 05:36:53 -0500 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C63CAC061357; Wed, 6 Jan 2021 02:36:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=bVpL1mGdE1znAIBZqUAoV1hHGWEPvW8K3ojw3xc9b+M=; b=omZNe+9FXXLxjBfSEMIE4cUKb3 rnyZVbDU3fbqcK9qpv/Ck2jBkMrwr3aQiL//361OiVvEoUbCdEFQu18X82YROGTWUED3YQ0MyJzgM h9Zaw3jVVldE335/DSoyOnvxXo+jexl+7ddRehUhOV5JaqMmuLtlcSvDPEh8L8ZAhX77gtaNDYnJP hBql9d3ZRNJfxEAyuCUpFDxIvk5GCmmht89lB5rnLjmnN+YFvZLcoJDI2kX3Mp5mV/MiowQoGMXi3 PBaiGYGtxll9pO/IlDnllQlS7f3wCuHU0XTGFXujT4c3l6p/wvHRX0iukAPsj5JAnvCPsRMELE7/r AAuiuMMA==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.94 #2 (Red Hat Linux)) id 1kx68E-002Ewa-Ib; Wed, 06 Jan 2021 10:34:05 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 99A053013E5; Wed, 6 Jan 2021 11:33:33 +0100 (CET) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 88C6E2029F4C3; Wed, 6 Jan 2021 11:33:33 +0100 (CET) Date: Wed, 6 Jan 2021 11:33:33 +0100 From: Peter Zijlstra To: Frederic Weisbecker Cc: LKML , "Rafael J . Wysocki" , Ingo Molnar , Fabio Estevam , stable@vger.kernel.org, Thomas Gleixner , "Paul E . McKenney" , Len Brown , Pengutronix Kernel Team , NXP Linux Team , Daniel Lezcano , Shawn Guo , Sascha Hauer Subject: Re: [PATCH 1/4] sched/idle: Fix missing need_resched() check after rcu_idle_enter() Message-ID: References: <20210104152058.36642-1-frederic@kernel.org> <20210104152058.36642-2-frederic@kernel.org> <20210105095503.GF3040@hirez.programming.kicks-ass.net> <20210105125722.GA68490@lothringen> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210105125722.GA68490@lothringen> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 05, 2021 at 01:57:22PM +0100, Frederic Weisbecker wrote: > > Something like the below, combined with a fixup for all callers (which > > the compiler will help us find thanks to __must_check). > > Right, I just need to make sure that the wake up is local as the kthread > awaken can be queued anywhere. But a simple need_resched() check after the > wake up should be fine to get that. Duh, yes. Clearly I'm having startup problems after the holidays ;-)