From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5BCC7C433E6 for ; Wed, 6 Jan 2021 12:28:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3056F23121 for ; Wed, 6 Jan 2021 12:28:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726700AbhAFM2Q (ORCPT ); Wed, 6 Jan 2021 07:28:16 -0500 Received: from mail.kernel.org ([198.145.29.99]:59678 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726576AbhAFM2O (ORCPT ); Wed, 6 Jan 2021 07:28:14 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 2492D205F4; Wed, 6 Jan 2021 12:27:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1609936053; bh=AjV2Q+OVfwxiH3Qul0Uz3pdpDvwVndFsEygdUMtHOrc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=OOIbYKqBKvqAgpSiY7GUsT+eqakMKfgcB8gZrBM5k8x5s0x7QG5xfVEPVyo+DIgSp ZHC4gojAc28aVah7jj21EulkowmVKrWoP+e+jvwKMnOSiJPMGogjf3+2tPoy5zi8JQ 102NkmpBz6d/lOZeIAS7H4j4q8fqdBUkzM9H93Ag= Date: Wed, 6 Jan 2021 13:28:54 +0100 From: "gregkh@linuxfoundation.org" To: =?utf-8?B?5p2O5o23?= Cc: "mst@redhat.com" , "kvm@vger.kernel.org" , "linux-kernel@vger.kernel.org" , =?utf-8?B?5L2V5YW0?= , =?utf-8?B?5ZCV6auY6aOe?= Subject: Re: [PATCH] uio: uio_pci_generic: don't fail probe if pdev->irq equals to IRQ_NOTCONNECTED Message-ID: References: <1269705030.4191784.1609933731961@mail-kr5-0> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1269705030.4191784.1609933731961@mail-kr5-0> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 06, 2021 at 07:48:51PM +0800, 李捷 wrote: > From 0fbcd7e386898d829d3000d094358a91e626ee4a Mon Sep 17 00:00:00 2001 > From: Jie Li > Date: Mon, 7 Dec 2020 08:05:07 +0800 > Subject: [PATCH] uio: uio_pci_generic: don't fail probe if pdev->irq equals to > IRQ_NOTCONNECTED > > Some devices use 255 as default value of Interrupt Line register, and this > maybe causes pdev->irq is set as IRQ_NOTCONNECTED in some scenarios. For > example, NVMe controller connects to Intel Volume Management Device (VMD). > In this situation, IRQ_NOTCONNECTED means INTx line is not connected, not > fault. If bind uio_pci_generic to these devices, uio frame will return > -ENOTCONN through request_irq. > > This patch allows binding uio_pci_generic to device with dev->irq of > IRQ_NOTCONNECTED. > > Signed-off-by: Jie Li > Acked-by: Kyungsan Kim > --- > drivers/uio/uio_pci_generic.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/uio/uio_pci_generic.c b/drivers/uio/uio_pci_generic.c > index b8e44d16279f..c7d681fef198 100644 > --- a/drivers/uio/uio_pci_generic.c > +++ b/drivers/uio/uio_pci_generic.c > @@ -92,7 +92,7 @@ static int probe(struct pci_dev *pdev, > gdev->info.version = DRIVER_VERSION; > gdev->info.release = release; > gdev->pdev = pdev; > - if (pdev->irq) { > + if (pdev->irq && (pdev->irq != IRQ_NOTCONNECTED)) { > gdev->info.irq = pdev->irq; > gdev->info.irq_flags = IRQF_SHARED; > gdev->info.handler = irqhandler; > -- > 2.17.1 > > > > > > Best regards, > > Jie Li > > [cid] > > * > Hi, This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree. You are receiving this message because of the following common error(s) as indicated below: - Your patch is malformed (tabs converted to spaces, linewrapped, etc.) and can not be applied. Please read the file, Documentation/email-clients.txt in order to fix this. - Your patch was attached, please place it inline so that it can be applied directly from the email message itself. If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers. thanks, greg k-h's patch email bot