From: Sean Christopherson <seanjc@google.com>
To: Maxim Levitsky <mlevitsk@redhat.com>
Cc: kvm@vger.kernel.org, Ingo Molnar <mingo@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>,
Paolo Bonzini <pbonzini@redhat.com>,
Sean Christopherson <sean.j.christopherson@intel.com>,
"open list:X86 ARCHITECTURE (32-BIT AND 64-BIT)"
<linux-kernel@vger.kernel.org>, Jim Mattson <jmattson@google.com>,
Joerg Roedel <joro@8bytes.org>,
"maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)"
<x86@kernel.org>, Wanpeng Li <wanpengli@tencent.com>,
"H. Peter Anvin" <hpa@zytor.com>,
Vitaly Kuznetsov <vkuznets@redhat.com>,
Borislav Petkov <bp@alien8.de>
Subject: Re: [PATCH 4/6] KVM: nSVM: correctly restore nested_run_pending on migration
Date: Wed, 6 Jan 2021 09:27:33 -0800 [thread overview]
Message-ID: <X/XzBUTPRhwVPCGx@google.com> (raw)
In-Reply-To: <20210106105001.449974-5-mlevitsk@redhat.com>
On Wed, Jan 06, 2021, Maxim Levitsky wrote:
> The code to store it on the migration exists, but no code was restoring it.
>
> Signed-off-by: Maxim Levitsky <mlevitsk@redhat.com>
> ---
> arch/x86/kvm/svm/nested.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/arch/x86/kvm/svm/nested.c b/arch/x86/kvm/svm/nested.c
> index 6208d3a5a3fdb..c1a3d0e996add 100644
> --- a/arch/x86/kvm/svm/nested.c
> +++ b/arch/x86/kvm/svm/nested.c
> @@ -1203,6 +1203,10 @@ static int svm_set_nested_state(struct kvm_vcpu *vcpu,
> * in the registers, the save area of the nested state instead
> * contains saved L1 state.
> */
> +
> + if (kvm_state->flags & KVM_STATE_NESTED_RUN_PENDING)
> + svm->nested.nested_run_pending = true;
This should be:
svm->nested.nested_run_pending =
!!(kvm_state->flags & KVM_STATE_NESTED_RUN_PENDING);
> +
> copy_vmcb_control_area(&hsave->control, &svm->vmcb->control);
> hsave->save = *save;
>
> --
> 2.26.2
>
next prev parent reply other threads:[~2021-01-06 17:28 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-06 10:49 [PATCH 0/6] KVM: nSVM: few random fixes Maxim Levitsky
2021-01-06 10:49 ` [PATCH 1/6] KVM: SVM: create svm_process_injected_event Maxim Levitsky
2021-01-06 10:49 ` [PATCH 2/6] KVM: nSVM: fix for disappearing L1->L2 event injection on L1 migration Maxim Levitsky
2021-01-06 10:49 ` [PATCH 3/6] KVM: nSVM: cancel KVM_REQ_GET_NESTED_STATE_PAGES on nested vmexit Maxim Levitsky
2021-01-06 10:49 ` [PATCH 4/6] KVM: nSVM: correctly restore nested_run_pending on migration Maxim Levitsky
2021-01-06 17:27 ` Sean Christopherson [this message]
2021-01-06 23:54 ` Maxim Levitsky
2021-01-06 10:50 ` [PATCH 5/6] KVM: nSVM: always leave the nested state first on KVM_SET_NESTED_STATE Maxim Levitsky
2021-01-06 17:39 ` Sean Christopherson
2021-01-06 23:55 ` Maxim Levitsky
2021-01-06 10:50 ` [PATCH 6/6] KVM: nSVM: mark vmcb as dirty when forcingly leaving the guest mode Maxim Levitsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=X/XzBUTPRhwVPCGx@google.com \
--to=seanjc@google.com \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=jmattson@google.com \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=mlevitsk@redhat.com \
--cc=pbonzini@redhat.com \
--cc=sean.j.christopherson@intel.com \
--cc=tglx@linutronix.de \
--cc=vkuznets@redhat.com \
--cc=wanpengli@tencent.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).