linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] Driver core: platform: Add extra error check in devm_platform_get_irqs_affinity()
@ 2020-12-21 14:30 John Garry
  2020-12-22  8:12 ` [irqchip: irq/irqchip-next] driver " irqchip-bot for John Garry
  2021-01-08 15:43 ` [PATCH] Driver " Greg KH
  0 siblings, 2 replies; 6+ messages in thread
From: John Garry @ 2020-12-21 14:30 UTC (permalink / raw)
  To: gregkh, rafael, maz, tglx; +Cc: linux-kernel, dan.carpenter, John Garry

The current check of nvec < minvec for nvec returned from
platform_irq_count() will not detect a negative error code in nvec.

This is because minvec is unsigned, and, as such, nvec is promoted to
unsigned in that check, which will make it a huge number (if it contained
-EPROBE_DEFER).

In practice, an error should not occur in nvec for the only in-tree
user, but add a check anyway.

Fixes: e15f2fa959f2 ("driver core: platform: Add devm_platform_get_irqs_affinity()")
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: John Garry <john.garry@huawei.com>
---
I hope that this can go through either irqchip or driver/core trees, thanks!

diff --git a/drivers/base/platform.c b/drivers/base/platform.c
index 95fd1549f87d..8456d8384ac8 100644
--- a/drivers/base/platform.c
+++ b/drivers/base/platform.c
@@ -366,6 +366,8 @@ int devm_platform_get_irqs_affinity(struct platform_device *dev,
 		return -ERANGE;
 
 	nvec = platform_irq_count(dev);
+	if (nvec < 0)
+		return nvec;
 
 	if (nvec < minvec)
 		return -ENOSPC;
-- 
2.26.2


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2021-01-08 16:06 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-21 14:30 [PATCH] Driver core: platform: Add extra error check in devm_platform_get_irqs_affinity() John Garry
2020-12-22  8:12 ` [irqchip: irq/irqchip-next] driver " irqchip-bot for John Garry
2021-01-08 15:43 ` [PATCH] Driver " Greg KH
2021-01-08 15:43   ` John Garry
2021-01-08 15:48     ` Marc Zyngier
2021-01-08 16:06       ` Greg KH

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).