From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB0D7C433E0 for ; Sun, 10 Jan 2021 11:17:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A172D22AB9 for ; Sun, 10 Jan 2021 11:17:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726389AbhAJLRb (ORCPT ); Sun, 10 Jan 2021 06:17:31 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56688 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726069AbhAJLRa (ORCPT ); Sun, 10 Jan 2021 06:17:30 -0500 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 84555C061786; Sun, 10 Jan 2021 03:16:49 -0800 (PST) Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id C645DDA; Sun, 10 Jan 2021 12:16:45 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1610277405; bh=PGy0AozDcrEmSiml7wOsTFqxOV88TZM0PfDLFlDrYhk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=mlEZLkQLihZHbMAtuf4sP9D+0HGeRr6dx8LmvXEEyqUEsEd2GFIb2seBoUiDk+nIc C2IUFb9o9U18fuigij5kKOFBWe73Y5gimhb6He2N4xPM7CAm2VdGd4LpsJGYrpObDQ SySEGoW+oxj4EeIr9akoIjcJdNREYW7+BdOtuoA8= Date: Sun, 10 Jan 2021 13:16:29 +0200 From: Laurent Pinchart To: Andy Shevchenko Cc: Petr Mladek , Steven Rostedt , Sergey Senozhatsky , Daniel Scally , "linux-kernel@vger.kernel.org" , "linux-acpi@vger.kernel.org" , "linux-media@vger.kernel.org" , "devel@acpica.org" , "rjw@rjwysocki.net" , "lenb@kernel.org" , "gregkh@linuxfoundation.org" , "mchehab@kernel.org" , "yong.zhi@intel.com" , "sakari.ailus@linux.intel.com" , "bingbu.cao@intel.com" , "tian.shu.qiu@intel.com" , "robert.moore@intel.com" , "erik.kaneda@intel.com" , "andriy.shevchenko@linux.intel.com" , "linux@rasmusvillemoes.dk" , "laurent.pinchart+renesas@ideasonboard.com" , "jacopo+renesas@jmondi.org" , "kieran.bingham+renesas@ideasonboard.com" , "hverkuil-cisco@xs4all.nl" , "m.felsch@pengutronix.de" , "niklas.soderlund+renesas@ragnatech.se" , "prabhakar.mahadev-lad.rj@bp.renesas.com" , "slongerbeam@gmail.com" , "heikki.krogerus@linux.intel.com" Subject: Re: [PATCH v5 09/15] lib/test_printf.c: Use helper function to unwind array of software_nodes Message-ID: References: <20210107132838.396641-1-djrscally@gmail.com> <20210107132838.396641-10-djrscally@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Andy, On Sat, Jan 09, 2021 at 11:07:33AM +0200, Andy Shevchenko wrote: > On Saturday, January 9, 2021, Laurent Pinchart wrote: > > > Hi Peter, Steven and Sergey, > > > > Could you please let us know if you're fine with this patch getting > > merged in v5.12 through the linux-media tree ? The cover letter contains > > additional details (in a nutshell, this is a cross-tree series and we > > would like to avoid topic branches if possible). > > There is already a tag by Petr. I saw that, but looking at the corresponding e-mail, there was no clear acknowledgement that we could merge this patch through a different tree. > > On Thu, Jan 07, 2021 at 01:28:32PM +0000, Daniel Scally wrote: > > > Use the software_node_unregister_nodes() helper function to unwind this > > > array in a cleaner way. > > > > > > Acked-by: Petr Mladek > > > Reviewed-by: Andy Shevchenko > > > Reviewed-by: Laurent Pinchart > > > Reviewed-by: Sergey Senozhatsky > > > Suggested-by: Andy Shevchenko > > > Signed-off-by: Daniel Scally > > > --- > > > Changes in v5: > > > > > > - None > > > > > > lib/test_printf.c | 4 +--- > > > 1 file changed, 1 insertion(+), 3 deletions(-) > > > > > > diff --git a/lib/test_printf.c b/lib/test_printf.c > > > index 7ac87f18a10f..7d60f24240a4 100644 > > > --- a/lib/test_printf.c > > > +++ b/lib/test_printf.c > > > @@ -644,9 +644,7 @@ static void __init fwnode_pointer(void) > > > test(second_name, "%pfwP", software_node_fwnode(&softnodes[1])); > > > test(third_name, "%pfwP", software_node_fwnode(&softnodes[2])); > > > > > > - software_node_unregister(&softnodes[2]); > > > - software_node_unregister(&softnodes[1]); > > > - software_node_unregister(&softnodes[0]); > > > + software_node_unregister_nodes(softnodes); > > > } > > > > > > static void __init -- Regards, Laurent Pinchart