From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D128BC433E0 for ; Sun, 10 Jan 2021 18:04:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9BF8C22473 for ; Sun, 10 Jan 2021 18:04:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726744AbhAJSEm (ORCPT ); Sun, 10 Jan 2021 13:04:42 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:60094 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726525AbhAJSEl (ORCPT ); Sun, 10 Jan 2021 13:04:41 -0500 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1kyf4F-00HLof-UD; Sun, 10 Jan 2021 19:03:55 +0100 Date: Sun, 10 Jan 2021 19:03:55 +0100 From: Andrew Lunn To: Stefan Chulski Cc: Russell King - ARM Linux admin , "netdev@vger.kernel.org" , "thomas.petazzoni@bootlin.com" , "davem@davemloft.net" , Nadav Haklai , Yan Markman , "linux-kernel@vger.kernel.org" , "kuba@kernel.org" , "mw@semihalf.com" , "atenart@kernel.org" Subject: Re: [EXT] Re: [PATCH RFC net-next 03/19] net: mvpp2: add CM3 SRAM memory map Message-ID: References: <1610292623-15564-1-git-send-email-stefanc@marvell.com> <1610292623-15564-4-git-send-email-stefanc@marvell.com> <20210110175500.GG1551@shell.armlinux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jan 10, 2021 at 05:57:14PM +0000, Stefan Chulski wrote: > > > + } else { > > > + priv->sram_pool = of_gen_pool_get(dn, "cm3-mem", 0); > > > + if (!priv->sram_pool) { > > > + dev_warn(&pdev->dev, "DT is too old, TX FC > > disabled\n"); > > > > I don't see anything in this patch that disables TX flow control, which means > > this warning message is misleading. > > OK, I would change to TX FC not supported. And you should tell phlylink, so it knows to disable it in autoneg. Which make me wonder, do we need a fix for stable? Has flow control never been support in this device up until these patches get merged? It should not be negotiated if it is not supported, which means telling phylink. Andrew