From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3A13C433E6 for ; Mon, 11 Jan 2021 18:24:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 70D782250E for ; Mon, 11 Jan 2021 18:24:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390323AbhAKSYN (ORCPT ); Mon, 11 Jan 2021 13:24:13 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60004 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390150AbhAKSYM (ORCPT ); Mon, 11 Jan 2021 13:24:12 -0500 Received: from mail-ot1-x331.google.com (mail-ot1-x331.google.com [IPv6:2607:f8b0:4864:20::331]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9B2E9C0617A2 for ; Mon, 11 Jan 2021 10:23:32 -0800 (PST) Received: by mail-ot1-x331.google.com with SMTP id n42so554331ota.12 for ; Mon, 11 Jan 2021 10:23:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=oHRRLRP3syrNXRgtXLe4zDZLAZUIXTDNntM1178Onx4=; b=Lp1keZgFL5eKc+p+U8+latPO0VrJ+THVD5+vETX/XbAZVYvwgTosayKSqfBl4lltLE prnwYmDyDqZjjpkZG8T/fbfotQ6/9AZe9de6vzX2LvnCC9Nv+KSQ2x/qNvGSxDLKSTdF amxHMiw4LqCC5QtpruCbAu3fVVPKQy91ziavo1befz2e23eqvTdKjqxycWNvOjrlUhcs Xt52rjVidw91lPqNouCwIpaozGhne9OrdiRIYZQYe2bbEi6E5nR2aU4mFIYzr32uRMcj RX10ysfFcmaxIWpq5Y+ZQjIklMACRFAa/bfh11s3Zf9e3cAaemVfkB5dWFn1RaHlh5O7 8sfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=oHRRLRP3syrNXRgtXLe4zDZLAZUIXTDNntM1178Onx4=; b=pC+fUG7imELkCzt/V9M/xR/oWRdcXGdthufUsbYZ2Fl+C3K1a06v4PxbWaSNK/WxL5 hK+u/ePkLSuOgu78Ga9i1mHL3+ncmEbUW7tgd3v6dwQiQHzfiIBJl4o7cg2fKcXRvHKx ViOzXDJ8Ruk0fhFs3URuWidUgtJsXItq23nFEsO6i9KFrJJaEYXi3m62CgU5wmc6x0px lXNdoL8ao+El1wOewzS2iGidpZgHMMDVEBW0zwzRuEfw5eMQQFxqRzBBBHAAzEkV5aOE uob+AFAHRwmmajua8OcPQoHFxvATwzMteN70AVSQ8fDSGCU0JycZ0d7qiTubeOZdPDlT OwAg== X-Gm-Message-State: AOAM533wN9Vg1rao+v4P0TNtWNsV7ppEojXLFHEPVkkIeHLtV+Ju0NAS B+pvNl/C2k3gTTqksvPqx5lIVA== X-Google-Smtp-Source: ABdhPJwSQkESyJB6Kz1cjy5okZasf3ZxNpivGY61xq/DZzbGSNQ/13Qf+v159Mg5XngNF2QuTl/ANg== X-Received: by 2002:a9d:65d7:: with SMTP id z23mr309029oth.131.1610389411993; Mon, 11 Jan 2021 10:23:31 -0800 (PST) Received: from builder.lan (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id f145sm58970oob.18.2021.01.11.10.23.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Jan 2021 10:23:31 -0800 (PST) Date: Mon, 11 Jan 2021 12:23:29 -0600 From: Bjorn Andersson To: Vinod Koul Cc: Mark Brown , Wolfram Sang , linux-arm-msm@vger.kernel.org, Andy Gross , Matthias Kaehlcke , Douglas Anderson , Sumit Semwal , Amit Pundir , linux-spi@vger.kernel.org, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 6/7] arm64: dts: qcom: sdm845: Add gpi dma node Message-ID: References: <20210111151651.1616813-1-vkoul@kernel.org> <20210111151651.1616813-7-vkoul@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210111151651.1616813-7-vkoul@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon 11 Jan 09:16 CST 2021, Vinod Koul wrote: > This add the device node for gpi dma0 instances found in sdm845. I think the 0 in "dma0" should go? Apart from that, this looks good. > > Signed-off-by: Vinod Koul > --- > arch/arm64/boot/dts/qcom/sdm845.dtsi | 46 ++++++++++++++++++++++++++++ > 1 file changed, 46 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi > index bcf888381f14..c9a127bbd606 100644 > --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi > +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi > @@ -1114,6 +1114,29 @@ opp-128000000 { > }; > }; > > + gpi_dma0: dma-controller@800000 { > + #dma-cells = <3>; Nit. I know #dma-cells are important to you ;) but I would prefer to have the standard properties (e.g. compatible) first. Regards, Bjorn > + compatible = "qcom,sdm845-gpi-dma"; > + reg = <0 0x00800000 0 0x60000>; > + interrupts = , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + ; > + dma-channels = <13>; > + dma-channel-mask = <0xfa>; > + iommus = <&apps_smmu 0x0016 0x0>; > + status = "disabled"; > + }; > + > qupv3_id_0: geniqup@8c0000 { > compatible = "qcom,geni-se-qup"; > reg = <0 0x008c0000 0 0x6000>; > @@ -1533,6 +1556,29 @@ uart7: serial@89c000 { > }; > }; > > + gpi_dma1: dma-controller@0xa00000 { > + #dma-cells = <3>; > + compatible = "qcom,sdm845-gpi-dma"; > + reg = <0 0x00a00000 0 0x60000>; > + interrupts = , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + ; > + dma-channels = <13>; > + dma-channel-mask = <0xfa>; > + iommus = <&apps_smmu 0x06d6 0x0>; > + status = "disabled"; > + }; > + > qupv3_id_1: geniqup@ac0000 { > compatible = "qcom,geni-se-qup"; > reg = <0 0x00ac0000 0 0x6000>; > -- > 2.26.2 >