From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6DD60C433E0 for ; Wed, 23 Dec 2020 17:58:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 32A7A221F8 for ; Wed, 23 Dec 2020 17:58:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727778AbgLWR6I (ORCPT ); Wed, 23 Dec 2020 12:58:08 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38646 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726923AbgLWR6I (ORCPT ); Wed, 23 Dec 2020 12:58:08 -0500 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7F160C061794; Wed, 23 Dec 2020 09:57:27 -0800 (PST) Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 663CE9E6; Wed, 23 Dec 2020 18:57:23 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1608746243; bh=aIE8xGXf1HCeioV2CtalepWGwUaG6UD1DR44h6nu1dw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=q984DeWns2WpIpS44Mmf+NBIdwZ0VKyg0sn0lxei+qgt/rfO6sWAZCb1+DVvQDi9o InOBPu2fmLsVSlUtYnX5YK6WtH1oGzHcsyyF5jg0UJ1C7Zr11yWf/HAantErvmp/qN OE98sGc1W7JKZP2xFooqGJIBJ0Zkab3u+qIoO3Hc= Date: Wed, 23 Dec 2020 19:57:15 +0200 From: Laurent Pinchart To: Rob Herring Cc: Sam Ravnborg , devicetree@vger.kernel.org, Linux-ALSA , Greg Kroah-Hartman , Linux USB List , "linux-kernel@vger.kernel.org" , dri-devel , Jassi Brar , Vinod Koul , Mark Brown , "open list:DMA GENERIC OFFLOAD ENGINE SUBSYSTEM" Subject: Re: [PATCH] dt-bindings: Drop redundant maxItems/items Message-ID: References: <20201222040645.1323611-1-robh@kernel.org> <20201222063908.GB3463004@ravnborg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Dec 23, 2020 at 10:54:26AM -0700, Rob Herring wrote: > On Mon, Dec 21, 2020 at 11:39 PM Sam Ravnborg wrote: > > > > Hi Rob, > > > > On Mon, Dec 21, 2020 at 09:06:45PM -0700, Rob Herring wrote: > > > 'maxItems' equal to the 'items' list length is redundant. 'maxItems' is > > > preferred for a single entry while greater than 1 should have an 'items' > > > list. > > > > > > A meta-schema check for this is pending once these existing cases are > > > fixed. > > > > > > Cc: Laurent Pinchart > > > Cc: Vinod Koul > > > Cc: Mark Brown > > > Cc: Greg Kroah-Hartman > > > Cc: Jassi Brar > > > Cc: dri-devel@lists.freedesktop.org > > > Cc: dmaengine@vger.kernel.org > > > Cc: alsa-devel@alsa-project.org > > > Cc: linux-usb@vger.kernel.org > > > Signed-off-by: Rob Herring > > > > With one comment below, > > Acked-by: Sam Ravnborg > > > > > --- > > > diff --git a/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml b/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml > > > index 737c1f47b7de..54c361d4a7af 100644 > > > --- a/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml > > > +++ b/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml > > > @@ -74,11 +74,8 @@ properties: > > > > > > phys: > > > maxItems: 1 > > > - items: > > > - - description: phandle + phy specifier pair. > > > > The description may help some people, so keeping the > > description and deleting maxItems would maybe be better. > > Do we really want to describe 'phys' hundreds of times? No. The > question I ask on the descriptions is could it be generated instead. I agree. If the description had mentioned why particular PHY was referenced, I would have kept that, but "the phy is a phy" is probably not something we want to duplicate everywhere. -- Regards, Laurent Pinchart