From: Lina Iyer <ilina@codeaurora.org>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: linux-kernel@vger.kernel.org, kernel test robot <lkp@intel.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
rnayak@codeaurora.org
Subject: Re: [PATCH -next] regulator: qcom-rpmh: fix build after QCOM_COMMAND_DB is tristate
Date: Sun, 27 Dec 2020 19:13:25 -0700 [thread overview]
Message-ID: <X+k/RZ1LnG2Wx7FH@codeaurora.org> (raw)
In-Reply-To: <20201225185004.20747-1-rdunlap@infradead.org>
On Fri, Dec 25 2020 at 11:50 -0700, Randy Dunlap wrote:
>Restrict REGULATOR_QCOM_RPMH to QCOM_COMMAND_DB it the latter is enabled.
>
>Fixes this build error:
> microblaze-linux-ld: drivers/regulator/qcom-rpmh-regulator.o: in function `rpmh_regulator_probe':
> (.text+0x354): undefined reference to `cmd_db_read_addr'
>
>Fixes: 778279f4f5e4 ("soc: qcom: cmd-db: allow loading as a module")
>Reported-by: kernel test robot <lkp@intel.com>
>Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
>Cc: Lina Iyer <ilina@codeaurora.org>
>Cc: Liam Girdwood <lgirdwood@gmail.com>
>Cc: Mark Brown <broonie@kernel.org>
Reviewed-by: Lina Iyer <ilina@codeaurora.org>
>---
> drivers/regulator/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
>--- linux-next-20201223.orig/drivers/regulator/Kconfig
>+++ linux-next-20201223/drivers/regulator/Kconfig
>@@ -881,6 +881,7 @@ config REGULATOR_QCOM_RPM
> config REGULATOR_QCOM_RPMH
> tristate "Qualcomm Technologies, Inc. RPMh regulator driver"
> depends on QCOM_RPMH || (QCOM_RPMH=n && COMPILE_TEST)
>+ depends on QCOM_COMMAND_DB || !QCOM_COMMAND_DB
> help
> This driver supports control of PMIC regulators via the RPMh hardware
> block found on Qualcomm Technologies Inc. SoCs. RPMh regulator
next prev parent reply other threads:[~2020-12-28 2:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-25 18:50 [PATCH -next] regulator: qcom-rpmh: fix build after QCOM_COMMAND_DB is tristate Randy Dunlap
2020-12-28 2:13 ` Lina Iyer [this message]
2020-12-28 16:13 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=X+k/RZ1LnG2Wx7FH@codeaurora.org \
--to=ilina@codeaurora.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=rdunlap@infradead.org \
--cc=rnayak@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).