From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17F20C433DB for ; Mon, 28 Dec 2020 06:35:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DEE6F20715 for ; Mon, 28 Dec 2020 06:35:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728020AbgL1Gfx (ORCPT ); Mon, 28 Dec 2020 01:35:53 -0500 Received: from mail.kernel.org ([198.145.29.99]:43940 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726511AbgL1Gfx (ORCPT ); Mon, 28 Dec 2020 01:35:53 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 4886120715; Mon, 28 Dec 2020 06:35:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1609137312; bh=tuuZcnd4yFMUkxjYB/o7BzJe7osRuH4BdWFrjJ43KxM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=PQHOtvte1kVQZgTZCfIWJRWo8MDb2BNoXlEnngQm4lTO/Qv4otduoNUoHBbT5TLwV btbQcE8ipZtb1ZPIM77wT80EHwdj4m80E1MahDAFtMtZsLvhHXLjtKP6HKk3mKFgMQ +XSYLs22K4qv/a1Nhv4R2Om9NMgUek4prfMF7Bq4= Date: Mon, 28 Dec 2020 07:35:07 +0100 From: Greg Kroah-Hartman To: jovin555 Cc: devel@driverdev.osuosl.org, Todd Kjos , linux-kernel@vger.kernel.org, Arve =?iso-8859-1?B?SGr4bm5lduVn?= , Joel Fernandes , Martijn Coenen , Christian Brauner Subject: Re: [PATCH] staging: android: ashmem: Declared file operation with const keyword Message-ID: References: <20201228051301.14983-1-jovin555@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201228051301.14983-1-jovin555@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Dec 28, 2020 at 12:13:00AM -0500, jovin555 wrote: > Warning found by checkpatch.pl script. > > Signed-off-by: jovin555 > --- > drivers/staging/android/ashmem.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/android/ashmem.c b/drivers/staging/android/ashmem.c > index c05a214191da..f9cfa15b785f 100644 > --- a/drivers/staging/android/ashmem.c > +++ b/drivers/staging/android/ashmem.c > @@ -367,7 +367,7 @@ ashmem_vmfile_get_unmapped_area(struct file *file, unsigned long addr, > > static int ashmem_mmap(struct file *file, struct vm_area_struct *vma) > { > - static struct file_operations vmfile_fops; > + static const struct file_operations vmfile_fops; > struct ashmem_area *asma = file->private_data; > int ret = 0; > Did you build your modified kernel with this change in it? Always do so... greg k-h