From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60A4BC433E9 for ; Mon, 28 Dec 2020 14:34:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 355732053B for ; Mon, 28 Dec 2020 14:34:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2505129AbgL1Od4 (ORCPT ); Mon, 28 Dec 2020 09:33:56 -0500 Received: from mail.kernel.org ([198.145.29.99]:40806 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2392119AbgL1Odm (ORCPT ); Mon, 28 Dec 2020 09:33:42 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 93BA4225AB; Mon, 28 Dec 2020 14:33:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1609166007; bh=jVzPh64KOHpk2wtB0i1401+raWRvFMw+qX6VfNWNKVw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fsrNpcHBGtIt0x6DWFK8BlEvhp9YsDF5iDFpZ5i1B6moNuprAIC7kVq/ZpfewLdrE sOi5bEqN/F1siFzTQECaRyUZvdWd/L1ITXxFjRsuxLWhe4A0TialonZ2CmqUdd6KIJ gLAkTIUQnY0z1Uua5VRPWYehfhJ4Nfvz2j19Z9v0= Date: Mon, 28 Dec 2020 15:11:14 +0100 From: Greg Kroah-Hartman To: Dinghao Liu Cc: kjlu@umn.edu, devel@driverdev.osuosl.org, Camylla Goncalves Cantanheide , Zhang Qilong , linux-kernel@vger.kernel.org, Colin Ian King , Allen Pais , Masahiro Yamada Subject: Re: [PATCH] staging: rtl8192u: Add null check in rtl8192_usb_initendpoints Message-ID: References: <20201226080258.6576-1-dinghao.liu@zju.edu.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201226080258.6576-1-dinghao.liu@zju.edu.cn> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Dec 26, 2020 at 04:02:56PM +0800, Dinghao Liu wrote: > There is an allocation for priv->rx_urb[16] has no null check, > which may lead to a null pointer dereference. > > Signed-off-by: Dinghao Liu > --- > drivers/staging/rtl8192u/r8192U_core.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/staging/rtl8192u/r8192U_core.c b/drivers/staging/rtl8192u/r8192U_core.c > index 93676af98629..9fc4adc83d77 100644 > --- a/drivers/staging/rtl8192u/r8192U_core.c > +++ b/drivers/staging/rtl8192u/r8192U_core.c > @@ -1608,6 +1608,8 @@ static short rtl8192_usb_initendpoints(struct net_device *dev) > void *oldaddr, *newaddr; > > priv->rx_urb[16] = usb_alloc_urb(0, GFP_KERNEL); > + if (!priv->rx_urb[16]) > + return -ENOMEM; > priv->oldaddr = kmalloc(16, GFP_KERNEL); > if (!priv->oldaddr) > return -ENOMEM; There is a bug here, where the memory is not freed from the alloc urb call, right? Anyway, something to fix up in a leter patch, thanks. greg k-h