From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: Xiaolei Wang <Xiaolei.Wang@windriver.com>,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
David Lechner <david@lechnology.com>,
Mark Brown <broonie@kernel.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Julia Lawall <julia.lawall@lip6.fr>
Subject: Re: [PATCH v3] regmap: debugfs: Fix a memory leak when calling regmap_attach_dev
Date: Wed, 30 Dec 2020 13:50:44 +0100 [thread overview]
Message-ID: <X+x3pIanr18Ep4ga@kroah.com> (raw)
In-Reply-To: <1503f5fa-1ad6-7675-6e02-6dc1eb04c1de@web.de>
On Wed, Dec 30, 2020 at 01:01:42PM +0100, Markus Elfring wrote:
> > Thank you very much, very good suggestion,
>
> Thanks for another positive feedback.
>
>
> > do I need to re-send a patch to fix this problem, or modify the previous patch and send it again?
>
> Please convince the involved contributors to integrate a corrected patch version.
>
> * Better indentation.
>
> * …
> >> + if (!map->debugfs_name)
> >> + kfree(map->debugfs_name);
>
> Would this questionable null pointer check result in a memory leak?
Hi,
This is the semi-friendly patch-bot of Greg Kroah-Hartman.
Markus, you seem to have sent a nonsensical or otherwise pointless
review comment to a patch submission on a Linux kernel developer mailing
list. I strongly suggest that you not do this anymore. Please do not
bother developers who are actively working to produce patches and
features with comments that, in the end, are a waste of time.
Patch submitter, please ignore Markus's suggestion; you do not need to
follow it at all. The person/bot/AI that sent it is being ignored by
almost all Linux kernel maintainers for having a persistent pattern of
behavior of producing distracting and pointless commentary, and
inability to adapt to feedback. Please feel free to also ignore emails
from them.
thanks,
greg k-h's patch email bot
next prev parent reply other threads:[~2020-12-30 12:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-29 10:50 [PATCH v3] regmap: debugfs: Fix a memory leak when calling regmap_attach_dev Xiaolei Wang
2020-12-29 14:32 ` Mark Brown
[not found] ` <d516efdd-7e66-13fe-3798-cdea5ff012dc@web.de>
2020-12-30 10:14 ` Wang, Xiaolei
[not found] ` <d463ff8b-306d-6f40-9115-1595d69edc95@web.de>
2020-12-30 12:37 ` Wang, Xiaolei
[not found] ` <932c5921-9ad3-e37b-5f31-4de69fa0ca8b@web.de>
[not found] ` <81f33869-32f6-650f-0f06-e2a5dce57236@web.de>
2021-01-04 14:17 ` [PATCH 1/2] regmap: debugfs: Delete a misplaced pointer check in regmap_debugfs_init() Greg Kroah-Hartman
[not found] ` <1503f5fa-1ad6-7675-6e02-6dc1eb04c1de@web.de>
2020-12-30 12:50 ` Greg Kroah-Hartman [this message]
2020-12-30 13:39 ` [PATCH v3] regmap: debugfs: Fix a memory leak when calling regmap_attach_dev Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=X+x3pIanr18Ep4ga@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=Markus.Elfring@web.de \
--cc=Xiaolei.Wang@windriver.com \
--cc=broonie@kernel.org \
--cc=david@lechnology.com \
--cc=julia.lawall@lip6.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).