From: Tejun Heo <tj@kernel.org>
To: Baolin Wang <baolin.wang@linux.alibaba.com>
Cc: axboe@kernel.dk, baolin.wang7@gmail.com,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/7] blk-iocost: Move the usage ratio calculation to the correct place
Date: Wed, 25 Nov 2020 07:19:43 -0500 [thread overview]
Message-ID: <X75L39ZY3GQ+eL0B@mtj.duckdns.org> (raw)
In-Reply-To: <89a6e1223944e96e0e5e001191d87dd8079345c8.1606186717.git.baolin.wang@linux.alibaba.com>
Hello,
> @@ -2225,6 +2207,25 @@ static void ioc_timer_fn(struct timer_list *timer)
> time_before64(vtime, now.vnow - ioc->margins.low))) {
> u32 hwa, old_hwi, hwm, new_hwi;
>
> + if (vdone != vtime) {
> + u64 inflight_us = DIV64_U64_ROUND_UP(
> + cost_to_abs_cost(vtime - vdone, hw_inuse),
> + ioc->vtime_base_rate);
> +
> + usage_us = max(usage_us, inflight_us);
> + }
> +
> + /* convert to hweight based usage ratio */
> + if (time_after64(iocg->activated_at, ioc->period_at))
> + usage_dur = max_t(u64, now.now - iocg->activated_at, 1);
> + else
> + usage_dur = max_t(u64, now.now - ioc->period_at, 1);
> +
> + usage = clamp_t(u32,
> + DIV64_U64_ROUND_UP(usage_us * WEIGHT_ONE,
> + usage_dur),
> + 1, WEIGHT_ONE);
Can you please move the variable declarations inside the block together with
the code?
Thanks.
--
tejun
next prev parent reply other threads:[~2020-11-25 12:20 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-24 3:33 [PATCH 0/7] Some cleanups and improvements for blk-iocost Baolin Wang
2020-11-24 3:33 ` [PATCH 1/7] blk-iocost: Fix some typos in comments Baolin Wang
2020-11-25 11:30 ` Tejun Heo
2020-11-24 3:33 ` [PATCH 2/7] blk-iocost: Remove unnecessary advance declaration Baolin Wang
2020-11-25 11:31 ` Tejun Heo
2020-11-24 3:33 ` [PATCH 3/7] blk-iocost: Just open code the q_name() Baolin Wang
2020-11-25 11:33 ` Tejun Heo
2020-11-25 13:35 ` Baolin Wang
2020-11-24 3:33 ` [PATCH 4/7] blk-iocost: Add a flag to indicate if need update hwi Baolin Wang
2020-11-25 12:14 ` Tejun Heo
2020-11-25 14:15 ` Baolin Wang
2020-11-25 14:35 ` Tejun Heo
2020-11-24 3:33 ` [PATCH 5/7] blk-iocost: Move the usage ratio calculation to the correct place Baolin Wang
2020-11-25 12:19 ` Tejun Heo [this message]
2020-11-25 13:36 ` Baolin Wang
2020-11-24 3:33 ` [PATCH 6/7] blk-iocost: Factor out the active iocgs' state check into a separate function Baolin Wang
2020-11-25 12:25 ` Tejun Heo
2020-11-25 13:37 ` Baolin Wang
2020-11-24 3:33 ` [PATCH 7/7] blk-iocost: Factor out the base vrate change " Baolin Wang
2020-11-25 12:30 ` Tejun Heo
2020-11-25 13:43 ` Baolin Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=X75L39ZY3GQ+eL0B@mtj.duckdns.org \
--to=tj@kernel.org \
--cc=axboe@kernel.dk \
--cc=baolin.wang7@gmail.com \
--cc=baolin.wang@linux.alibaba.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).