From: Tejun Heo <tj@kernel.org>
To: Hui Su <sh_def@163.com>
Cc: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fs/kernfs: remove the double check of dentry->inode
Date: Wed, 25 Nov 2020 07:49:23 -0500 [thread overview]
Message-ID: <X75S00hif93gcd/q@mtj.duckdns.org> (raw)
In-Reply-To: <20201113132143.GA119541@rlk>
On Fri, Nov 13, 2020 at 09:21:43PM +0800, Hui Su wrote:
> In both kernfs_node_from_dentry() and in
> kernfs_dentry_node(), we will check the dentry->inode
> is NULL or not, which is superfluous.
>
> So remove the check in kernfs_node_from_dentry().
>
> Signed-off-by: Hui Su <sh_def@163.com>
Acked-by: Tejun Heo <tj@kernel.org>
Thanks.
--
tejun
prev parent reply other threads:[~2020-11-25 12:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-13 13:21 [PATCH] fs/kernfs: remove the double check of dentry->inode Hui Su
2020-11-25 12:49 ` Tejun Heo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=X75S00hif93gcd/q@mtj.duckdns.org \
--to=tj@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sh_def@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).