From: Johan Hovold <johan@kernel.org>
To: Davidlohr Bueso <dave@stgolabs.net>
Cc: Johan Hovold <johan@kernel.org>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
Davidlohr Bueso <dbueso@suse.de>
Subject: Re: [PATCH v2] USB: serial: mos7720: defer state restore to a workqueue
Date: Wed, 18 Nov 2020 11:11:30 +0100 [thread overview]
Message-ID: <X7TzUr+nl+P4SL6c@localhost> (raw)
In-Reply-To: <20201117164837.vzhcumyoww3tf5ix@linux-p48b.lan>
On Tue, Nov 17, 2020 at 08:48:37AM -0800, Davidlohr Bueso wrote:
> The parallel port restore operation currently defers writes
> to a tasklet, if it sees a locked disconnect mutex. The
> driver goes to a lot of trouble to ensure writes happen
> in a non-blocking context, but things can be greatly
> simplified if it's done in regular process context and
> this is not a system performance critical path. As such,
> instead of doing the state restore writes in irq context,
> use a workqueue and just do regular synchronous writes.
>
> In addition to the cleanup, this also imposes less on the
> overall system as tasklets have been deprecated because
> of it's BH implications, potentially blocking a higher
> priority task from running. We also get rid of hacks
> such as trylocking a mutex in irq, something which does
So this was never done in irq either. Perhaps you can remove that bit
too.
> not play nice with priority boosting in PREEMPT_RT.
>
> Signed-off-by: Davidlohr Bueso <dbueso@suse.de>
> ---
> Changes from v1: remove bogus irq comment.
You seem to have some problem with your mail setup. The patch fails to
apply, and both checkpatch and git warn about the patch being corrupt:
warning: Patch sent with format=flowed; space at the end of lines might be lost.
Applying: USB: serial: mos7720: defer state restore to a workqueue
error: corrupt patch at line 12
Patch failed at 0001 USB: serial: mos7720: defer state restore to a workqueue
Can you look into that and verify that you can send the patch to
yourself and apply it first?
Johan
next prev parent reply other threads:[~2020-11-18 10:11 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-02 21:14 [PATCH] usb/mos7720: process deferred urbs in a workqueue Davidlohr Bueso
2020-11-03 20:40 ` Davidlohr Bueso
2020-11-04 11:06 ` Johan Hovold
2020-11-04 16:25 ` Johan Hovold
2020-11-05 0:13 ` Davidlohr Bueso
2020-11-05 8:25 ` Johan Hovold
2020-11-06 6:17 ` Davidlohr Bueso
2020-11-09 9:22 ` Oliver Neukum
2020-11-09 19:14 ` Davidlohr Bueso
2020-11-13 9:14 ` Johan Hovold
2020-11-14 4:27 ` [PATCH] USB: serial: mos7720: defer state restore to " Davidlohr Bueso
2020-11-16 17:09 ` Johan Hovold
2020-11-16 22:31 ` Davidlohr Bueso
2020-11-17 16:28 ` Johan Hovold
2020-11-17 16:48 ` [PATCH v2] " Davidlohr Bueso
2020-11-18 10:11 ` Johan Hovold [this message]
2020-11-20 4:53 ` [PATCH v3] " Davidlohr Bueso
2020-11-20 9:37 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=X7TzUr+nl+P4SL6c@localhost \
--to=johan@kernel.org \
--cc=dave@stgolabs.net \
--cc=dbueso@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).