From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3C6CC5519F for ; Fri, 20 Nov 2020 06:53:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4A96F22227 for ; Fri, 20 Nov 2020 06:53:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="FP1uX2OZ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726293AbgKTGxy (ORCPT ); Fri, 20 Nov 2020 01:53:54 -0500 Received: from mail.kernel.org ([198.145.29.99]:56690 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725766AbgKTGxy (ORCPT ); Fri, 20 Nov 2020 01:53:54 -0500 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3B75A21D7E; Fri, 20 Nov 2020 06:53:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1605855231; bh=SI/UGuj1NcWof+ZYBooGSM3cvmuOqdMcBYQ4qNkQTog=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=FP1uX2OZfoiGyeGhRekuaZRVCF/JBjpBXNB5+W97CHqmnwERMFjNaqyJAcHlUP5TL i6yqgnMmptSLrlJb5/yheKr8CQ7dcG1x5kJgmBxzy/K1h279t4TRwGjx0/Q66jU9EY eK50J6GaCXcrvQ5xYQwvvrwTVTysT7W+jzCBXJaI= Date: Fri, 20 Nov 2020 07:54:34 +0100 From: Greg Kroah-Hartman To: Min Guo Cc: Bin Liu , Matthias Brugger , chunfeng.yun@mediatek.com, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH] usb: musb: remove unused variable 'devctl' Message-ID: References: <20201117082125.7619-1-min.guo@mediatek.com> <1605854930.3995.8.camel@mhfsdcap03> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1605854930.3995.8.camel@mhfsdcap03> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 20, 2020 at 02:48:50PM +0800, Min Guo wrote: > Hi greg k-h: > On Wed, 2020-11-18 at 12:48 +0100, Greg Kroah-Hartman wrote: > > On Tue, Nov 17, 2020 at 04:21:25PM +0800, min.guo@mediatek.com wrote: > > > From: Min Guo > > > > > > Remove unused 'devctl' variable to fix compile warnings: > > > > > > drivers/usb/musb/musbhsdma.c: In function 'dma_controller_irq': > > > drivers/usb/musb/musbhsdma.c:324:8: warning: variable 'devctl' set > > > but not used [-Wunused-but-set-variable] > > > > > > Signed-off-by: Min Guo > > > --- > > > drivers/usb/musb/musbhsdma.c | 4 ---- > > > 1 file changed, 4 deletions(-) > > > > > > diff --git a/drivers/usb/musb/musbhsdma.c b/drivers/usb/musb/musbhsdma.c > > > index 0aacfc8be5a1..7acd1635850d 100644 > > > --- a/drivers/usb/musb/musbhsdma.c > > > +++ b/drivers/usb/musb/musbhsdma.c > > > @@ -321,8 +321,6 @@ irqreturn_t dma_controller_irq(int irq, void *private_data) > > > musb_channel->channel.status = > > > MUSB_DMA_STATUS_BUS_ABORT; > > > } else { > > > - u8 devctl; > > > - > > > addr = musb_read_hsdma_addr(mbase, > > > bchannel); > > > channel->actual_len = addr > > > @@ -336,8 +334,6 @@ irqreturn_t dma_controller_irq(int irq, void *private_data) > > > < musb_channel->len) ? > > > "=> reconfig 0" : "=> complete"); > > > > > > - devctl = musb_readb(mbase, MUSB_DEVCTL); > > > > Are you sure that the hardware does not require this read to complete > > the command? Lots of hardware is that way, so be very careful about > > this. Did you test it? > > I have tested this patch on Mediatek's platform, and not sure if it > will affect other vendors' platforms. > > Dear Bin: > > Does this patch will affect other vendors' platforms? The hardware specs will answer this question, what do they say about this read? thanks, greg k-h