linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Petr Mladek <pmladek@suse.com>
To: Hui Su <sh_def@163.com>
Cc: tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
	x86@kernel.org, hpa@zytor.com, 0x7f454c46@gmail.com,
	jroedel@suse.de, akpm@linux-foundation.org, jannh@google.com,
	mark.mossberg@gmail.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86/dumpstack: make show_trace_log_lvl() static
Date: Fri, 20 Nov 2020 10:50:03 +0100	[thread overview]
Message-ID: <X7eRSzvm98AOk9pZ@alley> (raw)
In-Reply-To: <20201113133943.GA136221@rlk>

On Fri 2020-11-13 21:39:43, Hui Su wrote:
> show_trace_log_lvl() won't be used by other files, so
> make it static and remove the declaration from the header
> file.
> 
> Signed-off-by: Hui Su <sh_def@163.com>

I would make sense to add:

Fixes: 16d1cb0bc43642a4d9 ("x86/dumpstack: Unify show_regs()")

Othrewise, it looks good:

Reviewed-by: Petr Mladek <pmladek@suse.com>

Best Regards,
Petr

      parent reply	other threads:[~2020-11-20  9:50 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-13 13:39 [PATCH] x86/dumpstack: make show_trace_log_lvl() static Hui Su
2020-11-17 18:24 ` [tip: x86/cleanups] x86/dumpstack: Make " tip-bot2 for Hui Su
2020-11-20  9:50 ` Petr Mladek [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=X7eRSzvm98AOk9pZ@alley \
    --to=pmladek@suse.com \
    --cc=0x7f454c46@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=bp@alien8.de \
    --cc=hpa@zytor.com \
    --cc=jannh@google.com \
    --cc=jroedel@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.mossberg@gmail.com \
    --cc=mingo@redhat.com \
    --cc=sh_def@163.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).