From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C362BC64E69 for ; Fri, 20 Nov 2020 15:45:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6528322252 for ; Fri, 20 Nov 2020 15:45:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="HdkU2jz7" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729939AbgKTPp1 (ORCPT ); Fri, 20 Nov 2020 10:45:27 -0500 Received: from mail.kernel.org ([198.145.29.99]:41548 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729562AbgKTPp0 (ORCPT ); Fri, 20 Nov 2020 10:45:26 -0500 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 449BC22252; Fri, 20 Nov 2020 15:45:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1605887125; bh=t4FPdIp/srlG0I4RLF89pJGn9GvpCylyQzugK7V4+Zo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=HdkU2jz7OREVIZbvId+gLMOwHXTw34eIztWCW4o+OWDJWTH5qRe3q3kpU2rlrG4fC O8v2pbTEyU96Lj5W4YRggenDsvRUWhkAk+LiI6M039qdhASUVwv0WxZqhF5wekbiab KU4FxYlN1e1EIRKU+LwKwxdsb0pek7ZSbZTwRQwE= Date: Fri, 20 Nov 2020 16:46:07 +0100 From: Greg KH To: Alexandru Ardelean Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH] uio/uio_pci_generic: remove unneeded pci_set_drvdata() Message-ID: References: <20201119145906.73727-1-alexandru.ardelean@analog.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201119145906.73727-1-alexandru.ardelean@analog.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 19, 2020 at 04:59:06PM +0200, Alexandru Ardelean wrote: > The pci_get_drvdata() was moved during commit ef84928cff58 > ("uio/uio_pci_generic: use device-managed function equivalents"). > > I should have notice that the pci_set_drvdata() requires a > pci_get_drvdata() for it to make sense. > > Signed-off-by: Alexandru Ardelean > --- > > Apologies for not noticing this sooner. > If this can be squashed into commit ef84928cff58 , then it's also fine. > I've started seeing that there actually more xxx_set_drvdata() leftovers > in the entire kernel, and I pinged the checkpatch crew to add a check > for this. > > https://lore.kernel.org/lkml/CA+U=Dspy5+RE9agcLr6eY9DCMa1c5+++0JLeugMMBRXz4YLj1w@mail.gmail.com/T/#u I can't squash existing public commits. Can you resend this and add a "Fixes:" tag to it to show what commit it fixes so we can track this properly? thanks, greg k-h