From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: min.guo@mediatek.com
Cc: Bin Liu <b-liu@ti.com>, Alan Stern <stern@rowland.harvard.edu>,
Matthias Brugger <matthias.bgg@gmail.com>,
chunfeng.yun@mediatek.com, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH v2] usb: musb: remove unused variable 'devctl'
Date: Tue, 24 Nov 2020 08:24:58 +0100 [thread overview]
Message-ID: <X7y1SpiRE+CcBQIa@kroah.com> (raw)
In-Reply-To: <20201124063613.28796-1-min.guo@mediatek.com>
On Tue, Nov 24, 2020 at 02:36:13PM +0800, min.guo@mediatek.com wrote:
> From: Min Guo <min.guo@mediatek.com>
>
> Remove unused 'devctl' variable to fix compile warnings:
>
> drivers/usb/musb/musbhsdma.c: In function 'dma_controller_irq':
> drivers/usb/musb/musbhsdma.c:324:8: warning: variable 'devctl' set
> but not used [-Wunused-but-set-variable]
>
> Signed-off-by: Min Guo <min.guo@mediatek.com>
> ---
> changes in v2
> suggested by Alan Stern:
> Add void before musb_read to indicate that the register MUSB_DEVCTL
> was intended to be read and discarded.
> ---
> drivers/usb/musb/musbhsdma.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/usb/musb/musbhsdma.c b/drivers/usb/musb/musbhsdma.c
> index 0aacfc8be5a1..f59a009c533e 100644
> --- a/drivers/usb/musb/musbhsdma.c
> +++ b/drivers/usb/musb/musbhsdma.c
> @@ -321,8 +321,6 @@ irqreturn_t dma_controller_irq(int irq, void *private_data)
> musb_channel->channel.status =
> MUSB_DMA_STATUS_BUS_ABORT;
> } else {
> - u8 devctl;
> -
> addr = musb_read_hsdma_addr(mbase,
> bchannel);
> channel->actual_len = addr
> @@ -336,7 +334,7 @@ irqreturn_t dma_controller_irq(int irq, void *private_data)
> < musb_channel->len) ?
> "=> reconfig 0" : "=> complete");
>
> - devctl = musb_readb(mbase, MUSB_DEVCTL);
> + (void)musb_readb(mbase, MUSB_DEVCTL);
Please put a comment here as to why the read is happening so that people
do not throw it away sometime in the future.
thanks,
greg k-h
prev parent reply other threads:[~2020-11-24 7:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-24 6:36 [PATCH v2] usb: musb: remove unused variable 'devctl' min.guo
2020-11-24 7:24 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=X7y1SpiRE+CcBQIa@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=b-liu@ti.com \
--cc=chunfeng.yun@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=min.guo@mediatek.com \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).