From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E4D00C433FE for ; Tue, 8 Dec 2020 20:39:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B5B1422582 for ; Tue, 8 Dec 2020 20:39:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729240AbgLHUjg (ORCPT ); Tue, 8 Dec 2020 15:39:36 -0500 Received: from mail.kernel.org ([198.145.29.99]:45012 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726694AbgLHUjd (ORCPT ); Tue, 8 Dec 2020 15:39:33 -0500 Date: Tue, 8 Dec 2020 20:51:15 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1607456997; bh=Hn6NwvPynuuwwJBvitAq6Fnqy3V2/I8AX+JshJwvimI=; h=From:To:Cc:Subject:References:In-Reply-To:From; b=pBHpqRlbM0n8LlZcjrRUfF1f4NhvdAyeCafQaH/2aefKOhooCxE9EVeGThq7Ax1nh 3638/nvEsfLn1tKGof2QDh/jkVQcoVMxIRROFonelKqjBz67hUFzlJtWFk8n2CYGE4 D7bxt+BMSuxgp5Rmr+1xaYV5znVuvxtGbtcdNlmA= From: Greg Kroah-Hartman To: Thierry Strudel Cc: "Rafael J. Wysocki" , Kevin Hilman , Ulf Hansson , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4] PM: domains: create debugfs nodes when adding power domains Message-ID: References: <20201208191955.2466057-1-tstrudel@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201208191955.2466057-1-tstrudel@google.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Dec 08, 2020 at 11:19:55AM -0800, Thierry Strudel wrote: > debugfs nodes were created in genpd_debug_init alled in late_initcall > preventing power domains registered though loadable modules to have > a debugfs entry. > > Create/remove debugfs nodes when the power domain is added/removed > to/from the internal gpd_list. > > Signed-off-by: Thierry Strudel > Change-Id: I8a2e0616746afe2a6bbd9c24bc3a0eaa84725a75 You don't need this, checkpatch.pl should have warned you :) > --- > v2: fix forward declaration and genpd_debugfs_dir being NULL - Ulf > v3: remove extra trailing char added by mistake in v2 - kernel test robot > v4: cleanup includes and regroup CONFIG_DEBUG_FS CPP blocks - Greg > drivers/base/power/domain.c | 73 +++++++++++++++++++++++-------------- > 1 file changed, 45 insertions(+), 28 deletions(-) Looks good to me, thanks for fixing it up. Rafael, will this go through your tree? Reviewed-by: Greg Kroah-Hartman