From: Greg KH <gregkh@linuxfoundation.org>
To: Akash Asthana <akashast@codeaurora.org>
Cc: bjorn.andersson@linaro.org, devicetree@vger.kernel.org,
linux-arm-msm@vger.kernel.org, linux-serial@vger.kernel.org,
mka@chromium.org, dianders@chromium.org,
linux-kernel@vger.kernel.org, saravanak@google.com
Subject: Re: [PATCH 3/3] Serial: Separate out earlycon support
Date: Mon, 7 Dec 2020 10:43:19 +0100 [thread overview]
Message-ID: <X835NxSOLM7+17T6@kroah.com> (raw)
In-Reply-To: <1607330847-15522-4-git-send-email-akashast@codeaurora.org>
On Mon, Dec 07, 2020 at 02:17:27PM +0530, Akash Asthana wrote:
> Separate out earlycon support from serial driver and remove it's
> dependency on QUP wrapper driver.
>
> This enable us to manage earlycon independently and we can re-use the
> same earlycon driver for android project which currently uses
> downstream version of QUP drivers.
>
> Signed-off-by: Akash Asthana <akashast@codeaurora.org>
> ---
> drivers/tty/serial/Kconfig | 9 +
> drivers/tty/serial/Makefile | 1 +
> drivers/tty/serial/qcom_geni_earlycon.c | 649 ++++++++++++++++++++++++++++++++
> drivers/tty/serial/qcom_geni_serial.c | 97 -----
> 4 files changed, 659 insertions(+), 97 deletions(-)
> create mode 100644 drivers/tty/serial/qcom_geni_earlycon.c
Nit, your subject line shoudl say somewhere that this is the qcom
earlycon driver/support, not "earlycon in general".
thanks,
greg k-h
next prev parent reply other threads:[~2020-12-07 9:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-07 8:47 [PATCH 0/3] Separate out earlycon Akash Asthana
2020-12-07 8:47 ` [PATCH 1/3] soc: qcom-geni-se: Cleanup the code to remove proxy votes Akash Asthana
2020-12-07 8:47 ` [PATCH 2/3] arm64: dts: qcom: sc7180: Remove QUP-CORE ICC path Akash Asthana
2020-12-07 8:47 ` [PATCH 3/3] Serial: Separate out earlycon support Akash Asthana
2020-12-07 9:11 ` Greg KH
2020-12-07 12:22 ` Akash Asthana
2020-12-07 13:55 ` Greg KH
2020-12-07 9:43 ` Greg KH [this message]
2020-12-07 12:23 ` Akash Asthana
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=X835NxSOLM7+17T6@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=akashast@codeaurora.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=mka@chromium.org \
--cc=saravanak@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).