From: Johan Hovold <johan@kernel.org>
To: Marc Zyngier <maz@kernel.org>
Cc: Johan Hovold <johan@kernel.org>,
linux-usb@vger.kernel.org, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org,
Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
kernel-team@android.com
Subject: Re: [PATCH 3/4] USB: serial: ftdi_sio: Log the CBUS GPIO validity
Date: Mon, 7 Dec 2020 16:19:39 +0100 [thread overview]
Message-ID: <X85IC5NvcWikXfZY@localhost> (raw)
In-Reply-To: <02b461244a33d5eb0620cfaa13c2b03e@kernel.org>
On Mon, Dec 07, 2020 at 03:00:37PM +0000, Marc Zyngier wrote:
> On 2020-12-07 14:29, Johan Hovold wrote:
> > On Fri, Dec 04, 2020 at 04:47:38PM +0000, Marc Zyngier wrote:
> >> + if (!bitmap_full(valid_mask, ngpios))
> >> + dev_warn_once(&port->dev, "Consider using a tool such as ftx-prog
> >> to enable GPIOs if required\n");
> >> +
> >
> > And again, this is not something that belongs in the logs of just about
> > every system with an attached ftdi device.
>
> Fine by me, this patch can be dropped without issue. After all,
> I now know how to deal with these chips.
>
> > While not possible to combine with the valid_mask approach, this is
> > something which we could otherwise add to the request() callback for
> > the
> > first request that fails due to the mux configuration.
>
> That was Linus' initial suggestion. But I think a consistent user
> API is more important than free advise in the kernel log.
I tend to agree. So since your valid-mask approach clearly has some
merit in that it marks the lines in use when using the new cdev
interface, perhaps we should stick with that.
Johan
next prev parent reply other threads:[~2020-12-07 15:20 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-04 16:47 [PATCH 0/4] USB: ftdio_sio: GPIO validity fixes Marc Zyngier
2020-12-04 16:47 ` [PATCH 1/4] gpiolib: cdev: Flag invalid GPIOs as used Marc Zyngier
2020-12-07 14:16 ` Johan Hovold
2020-12-07 14:59 ` Marc Zyngier
2020-12-09 9:25 ` Linus Walleij
2020-12-04 16:47 ` [PATCH 2/4] USB: serial: ftdi_sio: Report the valid GPIO lines to gpiolib Marc Zyngier
2020-12-09 9:28 ` Linus Walleij
2020-12-04 16:47 ` [PATCH 3/4] USB: serial: ftdi_sio: Log the CBUS GPIO validity Marc Zyngier
2020-12-07 14:29 ` Johan Hovold
2020-12-07 15:00 ` Marc Zyngier
2020-12-07 15:19 ` Johan Hovold [this message]
2020-12-09 9:35 ` Linus Walleij
2020-12-09 17:05 ` Johan Hovold
2020-12-09 17:39 ` Johan Hovold
2020-12-04 16:47 ` [PATCH 4/4] USB: serial: ftdi_sio: Drop GPIO line checking dead code Marc Zyngier
2020-12-07 9:55 ` [PATCH 0/4] USB: ftdio_sio: GPIO validity fixes Andy Shevchenko
2020-12-07 14:01 ` Johan Hovold
2020-12-07 14:41 ` Marc Zyngier
2020-12-07 15:08 ` Johan Hovold
2020-12-07 15:34 ` Marc Zyngier
2020-12-07 15:49 ` Johan Hovold
2020-12-09 9:20 ` Linus Walleij
2020-12-09 15:42 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=X85IC5NvcWikXfZY@localhost \
--to=johan@kernel.org \
--cc=bgolaszewski@baylibre.com \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-team@android.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=maz@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).