From: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
To: Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
"Mauro Carvalho Chehab" <mchehab@kernel.org>,
"Rob Herring" <robh+dt@kernel.org>,
"Liam Girdwood" <lgirdwood@gmail.com>,
"Hans Verkuil" <hverkuil@xs4all.nl>,
"Maxime Ripard" <mripard@kernel.org>,
"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
"Kévin L'hôpital" <kevin.lhopital@bootlin.com>
Subject: Re: [PATCH v2 1/3] dt-bindings: media: i2c: Add OV8865 bindings documentation
Date: Fri, 27 Nov 2020 15:30:00 +0100 [thread overview]
Message-ID: <X8ENaKmZ8faK2Y/H@aptenodytes> (raw)
In-Reply-To: <20201127135220.GR3940@paasikivi.fi.intel.com>
[-- Attachment #1: Type: text/plain, Size: 2970 bytes --]
Hi Sakari,
On Fri 27 Nov 20, 15:52, Sakari Ailus wrote:
> Hi Paul,
>
> On Fri, Nov 13, 2020 at 06:03:42PM +0100, Paul Kocialkowski wrote:
> > This introduces YAML bindings documentation for the OV8865
> > image sensor.
> >
> > Co-developed-by: Kévin L'hôpital <kevin.lhopital@bootlin.com>
> > Signed-off-by: Kévin L'hôpital <kevin.lhopital@bootlin.com>
> > Signed-off-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
> > ---
> > .../bindings/media/i2c/ovti,ov8865.yaml | 120 ++++++++++++++++++
> > 1 file changed, 120 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/media/i2c/ovti,ov8865.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/media/i2c/ovti,ov8865.yaml b/Documentation/devicetree/bindings/media/i2c/ovti,ov8865.yaml
> > new file mode 100644
> > index 000000000000..47af90d6ebea
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/media/i2c/ovti,ov8865.yaml
> > @@ -0,0 +1,120 @@
> > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/media/i2c/ovti,ov8865.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: OmniVision OV8865 Image Sensor Device Tree Bindings
> > +
> > +maintainers:
> > + - Paul Kocialkowski <paul.kocialkowski@bootlin.com>
> > +
> > +properties:
> > + compatible:
> > + const: ovti,ov8865
> > +
> > + reg:
> > + maxItems: 1
> > +
> > + clocks:
> > + items:
> > + - description: EXTCLK Clock
> > +
> > + assigned-clocks:
> > + maxItems: 1
> > +
> > + assigned-clock-rates:
> > + maxItems: 1
> > +
> > + dvdd-supply:
> > + description: Digital Domain Power Supply
> > +
> > + avdd-supply:
> > + description: Analog Domain Power Supply (internal AVDD is used if missing)
> > +
> > + dovdd-supply:
> > + description: I/O Domain Power Supply
> > +
> > + powerdown-gpios:
> > + maxItems: 1
> > + description: Power Down Pin GPIO Control (active low)
> > +
> > + reset-gpios:
> > + maxItems: 1
> > + description: Reset Pin GPIO Control (active low)
> > +
> > + port:
> > + type: object
> > + description: MIPI CSI-2 transmitter port
> > +
> > + properties:
> > + endpoint:
> > + type: object
> > +
> > + properties:
> > + remote-endpoint: true
> > +
> > + data-lanes:
> > + minItems: 1
> > + maxItems: 4
> > +
> > + required:
> > + - bus-type
> > + - data-lanes
> > + - remote-endpoint
>
> link-frequencies seems to be still missing here (same with the example).
Oh my bad, you're right.
Note that I found an issue in this series (as well as the ov5648 one)
so I will be reposting them anyways (likely later today).
Cheers,
Paul
--
Paul Kocialkowski, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-11-27 14:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-13 17:03 [PATCH v2 0/3] media: i2c: OV8865 image sensor support Paul Kocialkowski
2020-11-13 17:03 ` [PATCH v2 1/3] dt-bindings: media: i2c: Add OV8865 bindings documentation Paul Kocialkowski
2020-11-16 15:53 ` Rob Herring
2020-11-27 13:52 ` Sakari Ailus
2020-11-27 14:30 ` Paul Kocialkowski [this message]
2020-11-13 17:03 ` [PATCH v2 2/3] media: i2c: Add support for the OV8865 image sensor Paul Kocialkowski
2020-11-13 17:03 ` [PATCH NOT FOR MERGE v2 3/3] ARM: dts: sun8i: a83t: bananapi-m3: Enable MIPI CSI-2 with OV8865 Paul Kocialkowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=X8ENaKmZ8faK2Y/H@aptenodytes \
--to=paul.kocialkowski@bootlin.com \
--cc=devicetree@vger.kernel.org \
--cc=hverkuil@xs4all.nl \
--cc=kevin.lhopital@bootlin.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=mripard@kernel.org \
--cc=robh+dt@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).