From: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
To: Andreas Gruenbacher <agruenba@redhat.com>
Cc: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
Randy Dunlap <rdunlap@infradead.org>,
Christoph Hellwig <hch@lst.de>,
"Gustavo A. R. Silva" <gustavo@embeddedor.com>,
Namjae Jeon <linkinjeon@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Al Viro <viro@zeniv.linux.org.uk>, Jan Kara <jack@suse.cz>
Subject: Re: [PATCH] posix_acl.h: define missing ACL functions on non-posix-acl build
Date: Mon, 30 Nov 2020 22:28:03 +0900 [thread overview]
Message-ID: <X8TzY0rotaSZ2FYv@jagdpanzerIV.localdomain> (raw)
In-Reply-To: <CAHc6FU59uNEq4Xz8W7boG6y3+u3F1tz93RKSW+odM38rx37_9A@mail.gmail.com>
Hi,
On (20/11/30 14:09), Andreas Gruenbacher wrote:
>
> Sergey, what actual problem is your patch trying to solve? It sounds
> like this is either theoretical and pointless, or you're trying to
> build an external module that uses POSIX ACL functions that shouldn't
> be needed when CONFIG_FS_POSIX_ACL is disabled.
It's an external module, that OpenWRT folks build with !FS_POSIX_ACL.
It compiles just fine, but modprobe fails because there are several
exported ACL symbols that don't provide dummy definitions (which the
module in question didn't guard with ifdef-s).
> In the latter case, the external module will just end up including dead
> code, so the module should be fixed instead.
ifdef-s work. But since posix_acl.h already provides some dummy
definitions for exported symbols, I thought that that list can
be extended (become complete).
-ss
next prev parent reply other threads:[~2020-11-30 13:28 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-30 1:44 [PATCH] posix_acl.h: define missing ACL functions on non-posix-acl build Sergey Senozhatsky
2020-11-30 2:00 ` Randy Dunlap
2020-11-30 3:15 ` Sergey Senozhatsky
2020-11-30 3:17 ` Sergey Senozhatsky
2020-11-30 3:37 ` Sergey Senozhatsky
2020-11-30 4:00 ` Randy Dunlap
2020-11-30 13:09 ` Andreas Gruenbacher
2020-11-30 13:13 ` Andreas Gruenbacher
2020-11-30 13:28 ` Sergey Senozhatsky [this message]
2020-11-30 6:05 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=X8TzY0rotaSZ2FYv@jagdpanzerIV.localdomain \
--to=sergey.senozhatsky@gmail.com \
--cc=agruenba@redhat.com \
--cc=gustavo@embeddedor.com \
--cc=hch@lst.de \
--cc=jack@suse.cz \
--cc=linkinjeon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).