From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61006C64E7A for ; Tue, 1 Dec 2020 04:28:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 11FC3206A5 for ; Tue, 1 Dec 2020 04:28:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728332AbgLAE2F (ORCPT ); Mon, 30 Nov 2020 23:28:05 -0500 Received: from mail-pg1-f195.google.com ([209.85.215.195]:36186 "EHLO mail-pg1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727897AbgLAE2D (ORCPT ); Mon, 30 Nov 2020 23:28:03 -0500 Received: by mail-pg1-f195.google.com with SMTP id q3so456091pgr.3; Mon, 30 Nov 2020 20:27:42 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=XT7qPo4SGXKCq6WGsdPJ15AKTgAIRFMM6hQ6UeCR5IA=; b=axcuFVJs0KvUotSxC9mCU1sN2GfddPuLcuF05gM3w3D1WVH8bafqYvJlVw5NFUnkuK MUJfo1IhLLASK83t7LKwzbMHTe6qJiURQqVR5xrCzWYdzub9I28g7riOiEf0Pw8l4F51 Ic7Fbeynr6KiFYoUAyQvXIP/RBlODS4JpiCgvxDvwIn558FFCC50X71dymXQ/ylGYB6I 69y6JNUAGQmmPMSTPN5qevjf24ufUklElmXcsZZ0UvhbwCyiKmU99BiWa/3XeP+31g+m 2eorzcmvpIm884XJ233G5LhqifEwQAKNQE53hJe9Bzey0bfSbBfa0FAhp+46E1Sa7034 r+oQ== X-Gm-Message-State: AOAM531KYhM1Rj3bWt1DnOhhlVYOeW2MCkv3iOGTwpPg98pLcB//o+uw oxiz16JfS3ZFhTiKpAkD6tk= X-Google-Smtp-Source: ABdhPJxHYUPjg2ZPY3ZtH02J8vfeX9L6+Zq05J7yUCzOiaXJK4R+79fSUpxWc3YgrqNUOZstx9VQUg== X-Received: by 2002:a63:b60:: with SMTP id a32mr665828pgl.275.1606796836967; Mon, 30 Nov 2020 20:27:16 -0800 (PST) Received: from localhost ([2601:647:5b00:1162:1ac0:17a6:4cc6:d1ef]) by smtp.gmail.com with ESMTPSA id l1sm529559pju.48.2020.11.30.20.27.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Nov 2020 20:27:15 -0800 (PST) Date: Mon, 30 Nov 2020 20:27:15 -0800 From: Moritz Fischer To: Sonal Santan Cc: linux-kernel@vger.kernel.org, linux-fpga@vger.kernel.org, maxz@xilinx.com, lizhih@xilinx.com, michal.simek@xilinx.com, stefanos@xilinx.com, devicetree@vger.kernel.org Subject: Re: [PATCH Xilinx Alveo 2/8] fpga: xrt: Add UAPI header files Message-ID: References: <20201129000040.24777-1-sonals@xilinx.com> <20201129000040.24777-3-sonals@xilinx.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201129000040.24777-3-sonals@xilinx.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Sonal, On Sat, Nov 28, 2020 at 04:00:34PM -0800, Sonal Santan wrote: > From: Sonal Santan > > Add XRT UAPI header files which describe flash layout, XRT > mailbox protocol, xclBin/axlf FPGA image container format and > XRT management physical function driver ioctl interfaces. > > flash_xrt_data.h: > Layout used by XRT to store private data on flash. > > mailbox_proto.h: > Mailbox opcodes and high level data structures representing > various kinds of information like sensors, clock, etc. > > mailbox_transport.h: > Transport protocol used by mailbox. > > xclbin.h: > Container format used to store compiled FPGA image which includes > bitstream and metadata. Can these headers be introduced together with the code that uses them as logical change? I haven't looked too closely, but it helps reviewing if you can break it into smaller pieces that can stand by themselves. Thanks, Moritz