linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Re: [PATCH] tty/serial/imx: Enable TXEN bit in imx_poll_init().
       [not found] <tencent_20B71295BC0C2FCB5807D81BC045ED802C06@qq.com>
@ 2020-12-01 10:11 ` Greg KH
  0 siblings, 0 replies; only message in thread
From: Greg KH @ 2020-12-01 10:11 UTC (permalink / raw)
  To: jiladahe1997; +Cc: shawnguo, s.hauer, linux-imx, linux-kernel

On Tue, Dec 01, 2020 at 09:52:49AM +0800, jiladahe1997 wrote:
> From: Mingrui Ren <972931182@qq.com>
> 
> As described in Documentation, poll_init() is called by kgdb to initialize
> hardware which support both poll_put_char() and poll_get_char().
> 
> It's necessary to enable TXEN bit, otherwise, it will cause hardware fault
> and kernel panic when calling imx_poll_put_char().
> 
> Generally, if use /dev/ttymxc0 as kgdb console as well as system
> console, ttymxc0 is initialized early by system console which does enable TXEN
> bit.But when use /dev/ttymxc1 as kgbd console, ttymxc1 is only initialized by 
> imx_poll_init() cannot enable the TXEN bit, which will cause kernel panic.
> 
> Signed-off-by: Mingrui Ren <972931182@qq.com>
> ---
>  drivers/tty/serial/imx.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

You sent this twice?  Which one is "correct"?  I'll drop both from my
patch queue and wait for just one to be resent.

thanks,

greg k-h

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2020-12-01 10:10 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <tencent_20B71295BC0C2FCB5807D81BC045ED802C06@qq.com>
2020-12-01 10:11 ` [PATCH] tty/serial/imx: Enable TXEN bit in imx_poll_init() Greg KH

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).