From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2D68C4361A for ; Thu, 3 Dec 2020 19:25:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 88BDA221F5 for ; Thu, 3 Dec 2020 19:25:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729433AbgLCTZN (ORCPT ); Thu, 3 Dec 2020 14:25:13 -0500 Received: from mail.kernel.org ([198.145.29.99]:51786 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726620AbgLCTZM (ORCPT ); Thu, 3 Dec 2020 14:25:12 -0500 Date: Thu, 3 Dec 2020 20:25:38 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1607023471; bh=JfxMKscEXFAr7qsU4HRCSRGkP0Gtl8g3FpK77gye064=; h=From:To:Cc:Subject:References:In-Reply-To:From; b=T2zKbRO6v08ScuIgXkHtaNwqwEydsX9yQILAngxvYhkguocxNPd/J1K5NqmQbS0HX PHFS1PbSAgCa0Td8UV1YoD6UZrpjSGNIXpSwLq1BXV40KJTts8Fp0znp3RB/sv+Uzz lmyg+KpJCUbGzPyVbtDGfwAeIUmvc97v38Zsrz7w= From: Greg KH To: Lukas Bulwahn Cc: Aditya , Joe Perches , linux-kernel-mentees@lists.linuxfoundation.org, Linux Kernel Mailing List Subject: Re: [Linux-kernel-mentees] [PATCH -mmots] checkpatch: add fix for non-standard signature - co-authored-by Message-ID: References: <280235acc0e91365f3fd3b5be5a5244eced1ff61.camel@perches.com> <20201202183045.9309-1-yashsri421@gmail.com> <5afbcd1423ee8fc2dfad191d94aef6efc17198c8.camel@perches.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Dec 03, 2020 at 08:00:58PM +0100, Lukas Bulwahn wrote: > On Thu, Dec 3, 2020 at 7:56 PM Greg KH wrote: > > > > On Thu, Dec 03, 2020 at 11:59:54AM +0100, Lukas Bulwahn wrote: > > > On Thu, Dec 3, 2020 at 10:59 AM Aditya wrote: > > > > > > > > On 3/12/20 12:26 am, Joe Perches wrote: > > > > > On Thu, 2020-12-03 at 00:00 +0530, Aditya Srivastava wrote: > > > > >> Currently, checkpatch.pl warns us for BAD_SIGN_OFF on the usage of > > > > >> non-standard signatures. > > > > >> > > > > >> An evaluation on v4.13..v5.8 showed that out of 539 warnings due to > > > > >> non-standard signatures, 43 are due to the use of 'Co-authored-by' > > > > >> tag, which may seem correct, but is not standard. > > > > >> > > > > >> The standard signature equivalent for 'Co-authored-by' is > > > > >> 'Co-developed-by'. > > > > > > > > > > I'm not going to ack this as I don't mind non-standard signatures. > > > > > > > > > > > > > What do you suggest? > > > > Should I drop this patch and move on? > > > > > > > > > > Joe does not ack this, but he also does not nack it. > > > > > > You either move on (which is perfectly fine), or > > > > > > you either wait that Andrew Morton reviews it and accepts it because > > > he thinks it useful, or > > > > > > you reach out to the git committers that have been using > > > Co-authored-by in the past and ask them if this kind of feature would > > > have been helpful for them and you get an ack from them that convinces > > > Andrew Morton to pick this. > > > > co-developed-by is the correct tag for this. It is documented exactly > > for this reason, please do not try to use something that is not already > > accepted by the kernel developers for this type of thing. > > > > Well, Greg, so do we get your Acked-by on a feature that checkpatch > warns that Co-authored-by is non-standard and that then fixes up the > patch automatically to Co-developed-by with checkpatch --fix? > > If so, please add your Acked-by on this patch here and let Andrew know > to pick it... I have not reviewed the patch, sorry, just was commenting on the fact that we do have a standard for this. thanks, greg k-h