From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E76FC4361A for ; Fri, 4 Dec 2020 08:17:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C9069225A9 for ; Fri, 4 Dec 2020 08:17:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728849AbgLDIRJ (ORCPT ); Fri, 4 Dec 2020 03:17:09 -0500 Received: from mail.kernel.org ([198.145.29.99]:33348 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726763AbgLDIRI (ORCPT ); Fri, 4 Dec 2020 03:17:08 -0500 Date: Fri, 4 Dec 2020 09:17:33 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1607069788; bh=nH8hYoVi+qYnG9o1LKOwLqM+yBq7lDyRPc4Frhyv9Ek=; h=From:To:Cc:Subject:References:In-Reply-To:From; b=tVOcSkfCVxWnye88dEP2JLb8bDZ+B0AwPy5pfrkYuKMMr/aa4QXcTXN8JJ6ffjdEk HYM/QDK5tlrKR+MBmwI3MT6Dj4Cy2Abwd6S1oe3m/r6FY3alVY2iC24Ds/b5UrTYtx hx+qR95eVxkIBwSEGJj/bzZYA3qWQHK/PAAMRmgw= From: Greg Kroah-Hartman To: Jiri Slaby Cc: Jann Horn , linux-kernel@vger.kernel.org Subject: Re: [PATCH] tty: Remove dead termiox code Message-ID: References: <20201203020331.2394754-1-jannh@google.com> <5cca5126-60ba-d123-0f7d-47fdbac4c4db@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5cca5126-60ba-d123-0f7d-47fdbac4c4db@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Dec 04, 2020 at 08:22:41AM +0100, Jiri Slaby wrote: > On 03. 12. 20, 3:03, Jann Horn wrote: > > set_termiox() and the TCGETX handler bail out with -EINVAL immediately > > if ->termiox is NULL, but there are no code paths that can set > > ->termiox to a non-NULL pointer; and no such code paths seem to have > > existed since the termiox mechanism was introduced back in > > commit 1d65b4a088de ("tty: Add termiox") in v2.6.28. > > Similarly, no driver actually implements .set_termiox; and it looks like > > no driver ever has. > > Nice! > > > Delete this dead code; but leave the definition of struct termiox in the > > UAPI headers intact. > > I am thinking -- can/should we mark the structure as deprecated so that > userspace stops using it eventually? If it doesn't do anything, how can userspace even use it today? :)