* [PATCH] soc/tegra: fix T234 build failure
@ 2020-12-03 23:05 Arnd Bergmann
2020-12-04 11:09 ` Thierry Reding
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2020-12-03 23:05 UTC (permalink / raw)
To: Thierry Reding, Jonathan Hunter
Cc: Arnd Bergmann, Olof Johansson, JC Kuo, linux-tegra, linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
In a T234-only configuration, the fuse driver fails to build:
drivers/soc/tegra/fuse/fuse-tegra30.c:376:10: error: 'tegra30_fuse_read' undeclared here (not in a function); did you mean 'tegra_fuse_readl'?
Add the missing check in the #ifdef conditional.
Fixes: 1f44febf71ba ("soc/tegra: fuse: Add Tegra234 support")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/soc/tegra/fuse/fuse-tegra30.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/soc/tegra/fuse/fuse-tegra30.c b/drivers/soc/tegra/fuse/fuse-tegra30.c
index 9ea7f0168457..887402752688 100644
--- a/drivers/soc/tegra/fuse/fuse-tegra30.c
+++ b/drivers/soc/tegra/fuse/fuse-tegra30.c
@@ -37,7 +37,9 @@
defined(CONFIG_ARCH_TEGRA_132_SOC) || \
defined(CONFIG_ARCH_TEGRA_210_SOC) || \
defined(CONFIG_ARCH_TEGRA_186_SOC) || \
- defined(CONFIG_ARCH_TEGRA_194_SOC)
+ defined(CONFIG_ARCH_TEGRA_194_SOC) || \
+ defined(CONFIG_ARCH_TEGRA_234_SOC)
+
static u32 tegra30_fuse_read_early(struct tegra_fuse *fuse, unsigned int offset)
{
if (WARN_ON(!fuse->base))
--
2.27.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] soc/tegra: fix T234 build failure
2020-12-03 23:05 [PATCH] soc/tegra: fix T234 build failure Arnd Bergmann
@ 2020-12-04 11:09 ` Thierry Reding
0 siblings, 0 replies; 2+ messages in thread
From: Thierry Reding @ 2020-12-04 11:09 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Jonathan Hunter, Arnd Bergmann, Olof Johansson, JC Kuo,
linux-tegra, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 771 bytes --]
On Fri, Dec 04, 2020 at 12:05:47AM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> In a T234-only configuration, the fuse driver fails to build:
>
> drivers/soc/tegra/fuse/fuse-tegra30.c:376:10: error: 'tegra30_fuse_read' undeclared here (not in a function); did you mean 'tegra_fuse_readl'?
>
> Add the missing check in the #ifdef conditional.
>
> Fixes: 1f44febf71ba ("soc/tegra: fuse: Add Tegra234 support")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/soc/tegra/fuse/fuse-tegra30.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
Do you want me to pick this up, or are you going to apply it directly to
ARM SoC? Either way is fine with me, so:
Acked-by: Thierry Reding <treding@nvidia.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-12-04 11:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-03 23:05 [PATCH] soc/tegra: fix T234 build failure Arnd Bergmann
2020-12-04 11:09 ` Thierry Reding
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).