From: Greg KH <gregkh@linuxfoundation.org>
To: Leon Romanovsky <leonro@nvidia.com>
Cc: Dan Williams <dan.j.williams@intel.com>,
broonie@kernel.org, lgirdwood@gmail.com, davem@davemloft.net,
kuba@kernel.org, jgg@nvidia.com,
Kiran Patil <kiran.patil@intel.com>,
Ranjani Sridharan <ranjani.sridharan@linux.intel.com>,
Fred Oh <fred.oh@linux.intel.com>,
Dave Ertman <david.m.ertman@intel.com>,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
Shiraz Saleem <shiraz.saleem@intel.com>,
Parav Pandit <parav@mellanox.com>,
Martin Habets <mhabets@solarflare.com>,
linux-rdma@vger.kernel.org, netdev@vger.kernel.org,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [resend/standalone PATCH v4] Add auxiliary bus support
Date: Fri, 4 Dec 2020 13:59:22 +0100 [thread overview]
Message-ID: <X8oyqpxDQ4JV31tj@kroah.com> (raw)
In-Reply-To: <20201204123207.GH16543@unreal>
On Fri, Dec 04, 2020 at 02:32:07PM +0200, Leon Romanovsky wrote:
> On Fri, Dec 04, 2020 at 12:42:46PM +0100, Greg KH wrote:
> > On Wed, Dec 02, 2020 at 04:54:24PM -0800, Dan Williams wrote:
> > > From: Dave Ertman <david.m.ertman@intel.com>
> > >
> > > Add support for the Auxiliary Bus, auxiliary_device and auxiliary_driver.
> > > It enables drivers to create an auxiliary_device and bind an
> > > auxiliary_driver to it.
> > >
> > > The bus supports probe/remove shutdown and suspend/resume callbacks.
> > > Each auxiliary_device has a unique string based id; driver binds to
> > > an auxiliary_device based on this id through the bus.
> > >
> > > Co-developed-by: Kiran Patil <kiran.patil@intel.com>
> > > Co-developed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
> > > Co-developed-by: Fred Oh <fred.oh@linux.intel.com>
> > > Co-developed-by: Leon Romanovsky <leonro@nvidia.com>
> > > Signed-off-by: Kiran Patil <kiran.patil@intel.com>
> > > Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
> > > Signed-off-by: Fred Oh <fred.oh@linux.intel.com>
> > > Signed-off-by: Leon Romanovsky <leonro@nvidia.com>
> > > Signed-off-by: Dave Ertman <david.m.ertman@intel.com>
> > > Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
> > > Reviewed-by: Shiraz Saleem <shiraz.saleem@intel.com>
> > > Reviewed-by: Parav Pandit <parav@mellanox.com>
> > > Reviewed-by: Dan Williams <dan.j.williams@intel.com>
> > > Reviewed-by: Martin Habets <mhabets@solarflare.com>
> > > Link: https://lore.kernel.org/r/20201113161859.1775473-2-david.m.ertman@intel.com
> > > Signed-off-by: Dan Williams <dan.j.williams@intel.com>
> > > ---
> > > This patch is "To:" the maintainers that have a pending backlog of
> > > driver updates dependent on this facility, and "Cc:" Greg. Greg, I
> > > understand you have asked for more time to fully review this and apply
> > > it to driver-core.git, likely for v5.12, but please consider Acking it
> > > for v5.11 instead. It looks good to me and several other stakeholders.
> > > Namely, stakeholders that have pressure building up behind this facility
> > > in particular Mellanox RDMA, but also SOF, Intel Ethernet, and later on
> > > Compute Express Link.
> > >
> > > I will take the blame for the 2 months of silence that made this awkward
> > > to take through driver-core.git, but at the same time I do not want to
> > > see that communication mistake inconvenience other parties that
> > > reasonably thought this was shaping up to land in v5.11.
> > >
> > > I am willing to host this version at:
> > >
> > > git://git.kernel.org/pub/scm/linux/kernel/git/djbw/linux tags/auxiliary-bus-for-5.11
> > >
> > > ...for all the independent drivers to have a common commit baseline. It
> > > is not there yet pending Greg's Ack.
> > >
> > > For example implementations incorporating this patch, see Dave Ertman's
> > > SOF series:
> > >
> > > https://lore.kernel.org/r/20201113161859.1775473-2-david.m.ertman@intel.com
> > >
> > > ...and Leon's mlx5 series:
> > >
> > > http://lore.kernel.org/r/20201026111849.1035786-1-leon@kernel.org
> > >
> > > PS: Greg I know I promised some review on newcomer patches to help with
> > > your queue, unfortunately Intel-internal review is keeping my plate
> > > full. Again, I do not want other stakeholder to be waiting on me to
> > > resolve that backlog.
> >
> > Ok, I spent some hours today playing around with this. I wrote up a
> > small test-patch for this (how did anyone test this thing???).
>
> We are running all verifications tests that we have over our
> mlx5 driver. It includes devices reloads, power failures, FW
> reconfiguration to emulate different devices with and without error
> injections and many more. Up till now, no new bugs that are not known
> to us were found.
Yes, sorry, I was implying that the authors here had to create _some_
code to test this with, it would have been nice to include that as well
here. We are collecting more and more in-kernel tests, having one for
this code would be nice to also have so we make sure not to break any
functionality in the future.
thanks,
greg k-h
next prev parent reply other threads:[~2020-12-04 12:59 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-03 0:54 [resend/standalone PATCH v4] Add auxiliary bus support Dan Williams
2020-12-03 15:06 ` Greg KH
2020-12-04 2:33 ` Jason Gunthorpe
2020-12-04 3:37 ` Dan Williams
2020-12-03 15:07 ` Greg KH
2020-12-03 15:55 ` Leon Romanovsky
2020-12-04 11:42 ` Greg KH
2020-12-04 11:43 ` [PATCH 1/3] driver core: auxiliary bus: move slab.h from include file Greg KH
2020-12-04 11:44 ` [PATCH 2/3] driver core: auxiliary bus: make remove function return void Greg KH
2020-12-04 11:44 ` [PATCH 3/3] driver core: auxiliary bus: minor coding style tweaks Greg KH
2020-12-04 11:48 ` Greg KH
2020-12-04 11:49 ` [PATCH v2 " Greg KH
2020-12-04 12:32 ` [resend/standalone PATCH v4] Add auxiliary bus support Leon Romanovsky
2020-12-04 12:43 ` Parav Pandit
2020-12-04 12:59 ` Greg KH [this message]
2020-12-04 17:10 ` Ranjani Sridharan
2020-12-05 9:02 ` Greg KH
2020-12-04 16:41 ` Dan Williams
2020-12-05 15:51 ` Greg KH
2020-12-17 21:19 ` Alexandre Belloni
2020-12-18 2:39 ` Dan Williams
2020-12-18 14:20 ` Mark Brown
2020-12-18 7:10 ` Greg KH
2020-12-18 13:17 ` Mark Brown
2020-12-18 13:46 ` Lee Jones
2020-12-18 14:08 ` Jason Gunthorpe
2020-12-18 15:52 ` Mark Brown
2020-12-18 16:28 ` Jason Gunthorpe
2020-12-18 17:15 ` Alexandre Belloni
2020-12-18 18:03 ` Mark Brown
2020-12-18 18:41 ` Jason Gunthorpe
2020-12-18 19:09 ` Lee Jones
2020-12-18 20:14 ` Jason Gunthorpe
2020-12-18 20:32 ` Mark Brown
2020-12-18 20:58 ` Jason Gunthorpe
2020-12-18 21:16 ` Alexandre Belloni
2020-12-18 22:36 ` Dan Williams
2020-12-18 23:36 ` Jason Gunthorpe
2020-12-19 0:22 ` Alexandre Belloni
2020-12-21 18:51 ` Mark Brown
2021-01-04 18:08 ` Jason Gunthorpe
2021-01-04 21:19 ` Mark Brown
2021-01-05 0:13 ` Jason Gunthorpe
2021-01-05 0:51 ` Dan Williams
2021-01-05 1:53 ` Jason Gunthorpe
2021-01-05 3:12 ` Dan Williams
2021-01-05 12:49 ` Jason Gunthorpe
2021-01-05 13:42 ` Mark Brown
2021-01-05 14:36 ` Jason Gunthorpe
2021-01-05 15:47 ` Mark Brown
2020-12-04 12:35 ` Greg KH
2020-12-04 12:54 ` Leon Romanovsky
2020-12-04 16:25 ` Jakub Kicinski
2020-12-04 17:57 ` Saeed Mahameed
2020-12-04 18:05 ` Ranjani Sridharan
2020-12-06 0:24 ` David Ahern
2020-12-06 0:32 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=X8oyqpxDQ4JV31tj@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=dan.j.williams@intel.com \
--cc=davem@davemloft.net \
--cc=david.m.ertman@intel.com \
--cc=fred.oh@linux.intel.com \
--cc=jgg@nvidia.com \
--cc=kiran.patil@intel.com \
--cc=kuba@kernel.org \
--cc=leonro@nvidia.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=mhabets@solarflare.com \
--cc=netdev@vger.kernel.org \
--cc=parav@mellanox.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=ranjani.sridharan@linux.intel.com \
--cc=shiraz.saleem@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).