From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99FFDC433FE for ; Sat, 5 Dec 2020 10:07:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4DCCC22DFA for ; Sat, 5 Dec 2020 10:07:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728872AbgLEKGa (ORCPT ); Sat, 5 Dec 2020 05:06:30 -0500 Received: from isilmar-4.linta.de ([136.243.71.142]:47412 "EHLO isilmar-4.linta.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726043AbgLEKBZ (ORCPT ); Sat, 5 Dec 2020 05:01:25 -0500 X-isilmar-external: YES X-isilmar-external: YES X-isilmar-external: YES X-isilmar-external: YES X-isilmar-external: YES X-isilmar-external: YES Received: from light.dominikbrodowski.net (brodo.linta [10.2.0.102]) by isilmar-4.linta.de (Postfix) with ESMTPSA id 549A920110F; Sat, 5 Dec 2020 09:05:30 +0000 (UTC) Received: by light.dominikbrodowski.net (Postfix, from userid 1000) id 54C6620ECA; Sat, 5 Dec 2020 09:58:05 +0100 (CET) Date: Sat, 5 Dec 2020 09:58:05 +0100 From: Dominik Brodowski To: Wei Li Cc: Andrew Morton , "Peter Zijlstra (Intel)" , Olof Johansson , linux-kernel@vger.kernel.org, guohanjun@huawei.com Subject: Re: [PATCH] drivers/pcmcia: Fix error return code in electra_cf_probe() Message-ID: References: <20201124070040.3583-1-liwei391@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201124070040.3583-1-liwei391@huawei.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Tue, Nov 24, 2020 at 03:00:40PM +0800 schrieb Wei Li: > When it fails to call of_get_property(), it just jumps to 'fail1', > while the 'status' which will be returned is not updated. > > Fixes: 2b571a066a2f ("pcmcia: CompactFlash driver for PA Semi Electra boards") > Signed-off-by: Wei Li Thnaks for the patch. However, this issue is already fixed by commit f15480e947d4 ("pcmcia/electra_cf: Fix some return values in 'electra_cf_probe()' in case of error") in pcmcia-next. Thanks, Dominik