From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47B6DC2BB48 for ; Sat, 5 Dec 2020 18:44:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2532422E00 for ; Sat, 5 Dec 2020 18:44:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728003AbgLESn0 (ORCPT ); Sat, 5 Dec 2020 13:43:26 -0500 Received: from mail.kernel.org ([198.145.29.99]:51172 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726648AbgLEQzu (ORCPT ); Sat, 5 Dec 2020 11:55:50 -0500 Date: Sat, 5 Dec 2020 17:33:17 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1607185923; bh=Ne5s4xen1CUUAHvQS1v4vcWj2XVNt6JGtidkDM7djHY=; h=From:To:Cc:Subject:References:In-Reply-To:From; b=FnUNvAwTW6sVbi2KtbN+cqqgEiKU8P8I+1J8g1MZcUaTv1rjY5qOelo6lwCnkP6y/ ZHkz434hzxWWgnQlKaDfOHbUBCHk88WZnIR7psaQFpupDgLFi3jTcX1qwhoCDCDWY4 GokzWHchJC4F2/txE+WjQ/8mphYvjDyjzB7Hu6DQ= From: Greg KH To: Muchun Song Cc: rafael@kernel.org, Alexey Dobriyan , Andrew Morton , Johannes Weiner , Michal Hocko , Vladimir Davydov , Hugh Dickins , Will Deacon , Roman Gushchin , Mike Rapoport , Thomas Gleixner , esyr@redhat.com, peterx@redhat.com, krisman@collabora.com, Suren Baghdasaryan , avagin@openvz.org, Marco Elver , Randy Dunlap , Joonsoo Kim , LKML , linux-fsdevel , Linux Memory Management List , Cgroups Subject: Re: [External] Re: [PATCH 5/9] mm: memcontrol: convert NR_FILE_THPS account to pages Message-ID: References: <20201205130224.81607-1-songmuchun@bytedance.com> <20201205130224.81607-6-songmuchun@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Dec 05, 2020 at 11:39:24PM +0800, Muchun Song wrote: > On Sat, Dec 5, 2020 at 11:32 PM Greg KH wrote: > > > > On Sat, Dec 05, 2020 at 11:29:26PM +0800, Muchun Song wrote: > > > On Sat, Dec 5, 2020 at 10:09 PM Greg KH wrote: > > > > > > > > On Sat, Dec 05, 2020 at 09:02:20PM +0800, Muchun Song wrote: > > > > > Converrt NR_FILE_THPS account to pages. > > > > > > > > > > Signed-off-by: Muchun Song > > > > > --- > > > > > drivers/base/node.c | 3 +-- > > > > > fs/proc/meminfo.c | 2 +- > > > > > mm/filemap.c | 2 +- > > > > > mm/huge_memory.c | 3 ++- > > > > > mm/khugepaged.c | 2 +- > > > > > mm/memcontrol.c | 5 ++--- > > > > > 6 files changed, 8 insertions(+), 9 deletions(-) > > > > > > > > > > diff --git a/drivers/base/node.c b/drivers/base/node.c > > > > > index 05c369e93e16..f6a9521bbcf8 100644 > > > > > --- a/drivers/base/node.c > > > > > +++ b/drivers/base/node.c > > > > > @@ -466,8 +466,7 @@ static ssize_t node_read_meminfo(struct device *dev, > > > > > HPAGE_PMD_NR), > > > > > nid, K(node_page_state(pgdat, NR_SHMEM_PMDMAPPED) * > > > > > HPAGE_PMD_NR), > > > > > - nid, K(node_page_state(pgdat, NR_FILE_THPS) * > > > > > - HPAGE_PMD_NR), > > > > > + nid, K(node_page_state(pgdat, NR_FILE_THPS)), > > > > > > > > Again, is this changing a user-visable value? > > > > > > > > > > Of course not. > > > > > > In the previous, the NR_FILE_THPS account is like below: > > > > > > __mod_lruvec_page_state(page, NR_FILE_THPS, 1); > > > > > > With this patch, it is: > > > > > > __mod_lruvec_page_state(page, NR_FILE_THPS, HPAGE_PMD_NR); > > > > > > So the result is not changed from the view of user space. > > > > So you "broke" it on the previous patch and "fixed" it on this one? Why > > not just do it all in one patch? > > Sorry for the confusion. I mean that the "previous" is without all of this patch > series. So this series is aimed to convert the unit of all different THP vmstat > counters from HPAGE_PMD_NR to pages. Thanks. I'm sorry, I still do not understand. It looks to me that you are changing the number printed to userspace here. Where is the corrisponding change that changed the units for this function? Is it in this patch? If so, sorry, I did not see that at all... thanks, greg k-h