archive mirror
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <>
To: Dmitry Baryshkov <>
Cc: "Rafael J. Wysocki" <>,
	"Uwe Kleine-König" <>,
Subject: Re: [PATCH] driver core: platform: don't oops on unbound devices
Date: Sat, 12 Dec 2020 12:41:32 +0100	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Sat, Dec 12, 2020 at 04:14:26AM +0300, Dmitry Baryshkov wrote:
> Platform code stopped checking if the device is bound to the actual
> platform driver, thus calling non-existing drv->shutdown(). Verify that
> _dev->driver is not NULL before calling remove/shutdown callbacks.
> Signed-off-by: Dmitry Baryshkov <>
> Fixes: 9c30921fe799 ("driver core: platform: use bus_type functions")
> ---
>  drivers/base/platform.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> diff --git a/drivers/base/platform.c b/drivers/base/platform.c
> index 0358dc3ea3ad..93f44e69b472 100644
> --- a/drivers/base/platform.c
> +++ b/drivers/base/platform.c
> @@ -1342,7 +1342,7 @@ static int platform_remove(struct device *_dev)
>  	struct platform_device *dev = to_platform_device(_dev);
>  	int ret = 0;
> -	if (drv->remove)
> +	if (_dev->driver && drv->remove)
>  		ret = drv->remove(dev);
>  	dev_pm_domain_detach(_dev, true);

I don't object to this, but it always feels odd to be doing pointer math
on a NULL value, wait until the static-checkers get ahold of this and
you get crazy emails saying you are crashing the kernel (hint, they are

But, I don't see why this check is needed?  If a driver is not bound to
a device, shouldn't this whole function just not be called?  Or error
out at the top?  

Uwe, I'd really like your review/ack of this before taking it.


greg k-h

  reply	other threads:[~2020-12-12 11:41 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-12  1:14 [PATCH] driver core: platform: don't oops on unbound devices Dmitry Baryshkov
2020-12-12 11:41 ` Greg Kroah-Hartman [this message]
2020-12-12 15:39   ` Uwe Kleine-König
2020-12-12 20:49     ` Dmitry Baryshkov
2020-12-12 21:09       ` Uwe Kleine-König

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).