From: Benjamin Block <bblock@linux.ibm.com>
To: Qinglang Miao <miaoqinglang@huawei.com>
Cc: Steffen Maier <maier@linux.ibm.com>,
Heiko Carstens <hca@linux.ibm.com>,
Vasily Gorbik <gor@linux.ibm.com>,
Christian Borntraeger <borntraeger@de.ibm.com>,
<linux-s390@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] scsi: zfcp: move the position of put_device
Date: Mon, 14 Dec 2020 13:49:52 +0100 [thread overview]
Message-ID: <X9dfcBC/qqUc4bmh@t480-pf1aa2c2.linux.ibm.com> (raw)
In-Reply-To: <20201201024716.42926-1-miaoqinglang@huawei.com>
On Tue, Dec 01, 2020 at 10:47:16AM +0800, Qinglang Miao wrote:
> Have the `put_device()` call after `device_unregister()` in both
> `zfcp_unit_remove()` and `zfcp_sysfs_port_remove_store()` to make
> it more natural, for put_device() ought to be the last time we
> touch the object in both functions.
>
> And add comments after put_device to make codes clearer.
>
> Suggested-by: Steffen Maier <maier@linux.ibm.com>
> Suggested-by: Benjamin Block <bblock@linux.ibm.com>
> Signed-off-by: Qinglang Miao <miaoqinglang@huawei.com>
> ---
> v2: add comments after put_device as Steffen suggested.
>
> drivers/s390/scsi/zfcp_sysfs.c | 4 ++--
> drivers/s390/scsi/zfcp_unit.c | 4 ++--
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
Got a bit delayed.
Looks good, I queue it, and we send it with the changes for 5.12 once
the merge window for 5.11 is over.
Thanks.
--
Best Regards, Benjamin Block / Linux on IBM Z Kernel Development / IBM Systems
IBM Deutschland Research & Development GmbH / https://www.ibm.com/privacy
Vorsitz. AufsR.: Gregor Pillen / Geschäftsführung: Dirk Wittkopp
Sitz der Gesellschaft: Böblingen / Registergericht: AmtsG Stuttgart, HRB 243294
prev parent reply other threads:[~2020-12-14 12:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-01 2:47 [PATCH v2] scsi: zfcp: move the position of put_device Qinglang Miao
2020-12-14 12:49 ` Benjamin Block [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=X9dfcBC/qqUc4bmh@t480-pf1aa2c2.linux.ibm.com \
--to=bblock@linux.ibm.com \
--cc=borntraeger@de.ibm.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=maier@linux.ibm.com \
--cc=miaoqinglang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).