From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17990C4361B for ; Mon, 14 Dec 2020 16:23:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C93A92075B for ; Mon, 14 Dec 2020 16:23:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2440248AbgLNQX2 (ORCPT ); Mon, 14 Dec 2020 11:23:28 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34408 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2439790AbgLNQXG (ORCPT ); Mon, 14 Dec 2020 11:23:06 -0500 Received: from mail-oi1-x241.google.com (mail-oi1-x241.google.com [IPv6:2607:f8b0:4864:20::241]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B3B93C0617A7 for ; Mon, 14 Dec 2020 08:21:47 -0800 (PST) Received: by mail-oi1-x241.google.com with SMTP id l207so19780606oib.4 for ; Mon, 14 Dec 2020 08:21:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=dypRW42Ag7SaNLUbf+uRP+IPcXW54P4LYSzuOs3g98U=; b=YUpN5dXm3OUT+XIzfFv0/IsmZDizXudCOrliTwPuAwdNhNisqhZHrinOtRIsBM+Pci KUd191tAFdQgNa8BuTyJdi89g2JmKTlm98C5axup3HYhao4ko9xKSrzDEOq3KwWNYnFq B3SWlKDwYV5QpeEqru6dF8bLBOgBpt6Of+DjlDnbbh/YaX3hNEQNRDL+3lCHSxHJwXcs vF//zSrAvlVhDG9jQX6RWMWQkceoV38s+amNbh7HMpqaUy/eENJ4yMEz5iMpQV6rnNQK y0DCREvCBXKnFwcFeuCFKfDC/zbnM3IOIy3heJeztRYf1vqdvhXZqms1or0xbJuhee1o Qs3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=dypRW42Ag7SaNLUbf+uRP+IPcXW54P4LYSzuOs3g98U=; b=BUKhKfkJsTXK6Fzd80WbcLKakyeJfDLEENhRnYdpRRfqPqrftUh6A9mDQTHS+R6Yrk LO/uEDohsz1NCZ5mhdNnUIiw0tYWMQzqYZ6ETE9SDjbsXDkE1Whcnxlj/fZzT/6UJ8eL GDE0umuGxHpcG9V5jaaGS6T9yyvrdZvloRJm3svyklMV1SXJpeFisoi3CYypvZewBG2K EozOj75xnkfsP54VH4BYpDR4QyWByNBq5l3lAkRrmAm83eU2CIbUVR3q+cgZvZkaSJ1/ 4u2dm2KnTn9nXgMP4Hz45OevhGBInAZcSGR+ljZUo5ST4EN33pD6H9ccm1nhdIwqyYGP 0DsQ== X-Gm-Message-State: AOAM53181Ohz0fGHcT5TuVezSx9z9rgN72o2asgqAdJvkwf0Kr6yXEJ2 /rg+JHqsohS/si1ogziQ05qTNA== X-Google-Smtp-Source: ABdhPJytx4fAQVDhA0UmXOWYQZ4w31/WKetaPmA3PWn5pcAwVbQgOFRfKCsJK7iHTnq3U5Vymw2H7w== X-Received: by 2002:aca:ed51:: with SMTP id l78mr2098851oih.144.1607962906753; Mon, 14 Dec 2020 08:21:46 -0800 (PST) Received: from builder.lan (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id k71sm4180810otk.48.2020.12.14.08.21.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Dec 2020 08:21:45 -0800 (PST) Date: Mon, 14 Dec 2020 10:21:44 -0600 From: Bjorn Andersson To: Zheng Yongjun Cc: agross@kernel.org, joro@8bytes.org, will@kernel.org, linux-arm-msm@vger.kernel.org, iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH -next] iommu: msm_iommu: Delete useless kfree code Message-ID: References: <20201214134746.5044-1-zhengyongjun3@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201214134746.5044-1-zhengyongjun3@huawei.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon 14 Dec 07:47 CST 2020, Zheng Yongjun wrote: > The parameter of kfree function is NULL, so kfree code is useless, delete it. > > Signed-off-by: Zheng Yongjun Reviewed-by: Bjorn Andersson Regards, Bjorn > --- > drivers/iommu/msm_iommu.c | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git a/drivers/iommu/msm_iommu.c b/drivers/iommu/msm_iommu.c > index 3615cd6241c4..1286674a1322 100644 > --- a/drivers/iommu/msm_iommu.c > +++ b/drivers/iommu/msm_iommu.c > @@ -319,7 +319,7 @@ static struct iommu_domain *msm_iommu_domain_alloc(unsigned type) > > priv = kzalloc(sizeof(*priv), GFP_KERNEL); > if (!priv) > - goto fail_nomem; > + return NULL; > > INIT_LIST_HEAD(&priv->list_attached); > > @@ -328,10 +328,6 @@ static struct iommu_domain *msm_iommu_domain_alloc(unsigned type) > priv->domain.geometry.force_aperture = true; > > return &priv->domain; > - > -fail_nomem: > - kfree(priv); > - return NULL; > } > > static void msm_iommu_domain_free(struct iommu_domain *domain) > -- > 2.22.0 >