From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 982DFC2BBCD for ; Wed, 16 Dec 2020 17:17:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6389423382 for ; Wed, 16 Dec 2020 17:17:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727083AbgLPRRz (ORCPT ); Wed, 16 Dec 2020 12:17:55 -0500 Received: from perceval.ideasonboard.com ([213.167.242.64]:42868 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727071AbgLPRRz (ORCPT ); Wed, 16 Dec 2020 12:17:55 -0500 Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 683482CF; Wed, 16 Dec 2020 18:17:12 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1608139032; bh=W9YanIGwZONXqwRTj+UtztRqLzatG/3UateoWE4Lj5M=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=RSrORiqo52IGgnPFTqEig21c+wCtHJnVXiTwtpYrt3OM/Uwwlatl15cz1tc7vbi6b EMyyhFEZrB5vhGGqForlJjKDekOqDHKTys2AfV+2f2MOAWd94LDU8aPuhkawxoF5Ou fwsDc4An9LjNQ202AyBAL4oxAeVmjcWlqbqkFduM= Date: Wed, 16 Dec 2020 19:17:05 +0200 From: Laurent Pinchart To: Jacopo Mondi Cc: kieran.bingham+renesas@ideasonboard.com, laurent.pinchart+renesas@ideasonboard.com, niklas.soderlund+renesas@ragnatech.se, geert@linux-m68k.org, robh@kernel.org, devicetree@vger.kernel.org, linux-media@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Hyun Kwon , Manivannan Sadhasivam , sergei.shtylyov@gmail.com Subject: Re: [PATCH v6 2/5] dt-bindings: media: max9286: Document 'maxim,reverse-channel-microvolt' Message-ID: References: <20201215170957.92761-1-jacopo+renesas@jmondi.org> <20201215170957.92761-3-jacopo+renesas@jmondi.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Dec 16, 2020 at 07:05:34PM +0200, Laurent Pinchart wrote: > Hi Jacopo, > > Thank you for the patch. > > On Tue, Dec 15, 2020 at 06:09:54PM +0100, Jacopo Mondi wrote: > > Document the 'reverse-channel-microvolt' vendor property in the > > bindings document of the max9286 driver. > > > > The newly introduced property allows to specifying the initial > > configuration of the GMSL reverse control channel to accommodate > > remote serializers pre-programmed with the high threshold power > > supply noise immunity enabled. > > > > Reviewed-by: Kieran Bingham > > Signed-off-by: Jacopo Mondi > > Reviewed-by: Laurent Pinchart > > > --- > > v5->v6: > > - Use standard unit suffix 'microvolt' for the custom property > > - Drop '$ref' as according to 'example-schema.yaml': > > "Vendor specific properties having a standard unit suffix don't need a type." > > --- > > .../bindings/media/i2c/maxim,max9286.yaml | 23 +++++++++++++++++++ > > 1 file changed, 23 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/media/i2c/maxim,max9286.yaml b/Documentation/devicetree/bindings/media/i2c/maxim,max9286.yaml > > index 9ea827092fdd..b22ba3e0db4a 100644 > > --- a/Documentation/devicetree/bindings/media/i2c/maxim,max9286.yaml > > +++ b/Documentation/devicetree/bindings/media/i2c/maxim,max9286.yaml > > @@ -51,6 +51,26 @@ properties: > > '#gpio-cells': > > const: 2 > > > > + maxim,reverse-channel-microvolt: > > + minimum: 30000 > > + maximum: 200000 > > + default: 170000 > > + description: | > > + Initial amplitude of the reverse control channel, in micro volts. > > + > > + The initial amplitude shall be adjusted to a value compatible with the > > + configuration of the connected remote serializer. > > + > > + Some camera modules (for example RDACM20) include an on-board MCU that > > + pre-programs the embedded serializer with power supply noise immunity > > + (high-threshold) enabled. A typical value of the deserializer's reverse > > + channel amplitude to communicate with pre-programmed serializers is > > + 170000 micro volts. > > + > > + A typical value for the reverse channel amplitude to communicate with > > + a remote serializer whose high-threshold noise immunity is not enabled > > + is 100000 micro volts > > + > > ports: > > type: object > > description: | > > @@ -221,6 +241,7 @@ required: > > - ports > > - i2c-mux > > - gpio-controller > > + - maxim,reverse-channel-microvolt One comment though: You specify a default value above, which isn't very useful when the property is required. Should we either drop the default value, or make the property optional ? > > > > additionalProperties: false > > > > @@ -243,6 +264,8 @@ examples: > > gpio-controller; > > #gpio-cells = <2>; > > > > + maxim,reverse-channel-microvolt = <170000>; > > + > > ports { > > #address-cells = <1>; > > #size-cells = <0>; -- Regards, Laurent Pinchart