From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1F56C4361B for ; Thu, 17 Dec 2020 03:57:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 66D272376F for ; Thu, 17 Dec 2020 03:57:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727892AbgLQD5u (ORCPT ); Wed, 16 Dec 2020 22:57:50 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52128 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727233AbgLQD5u (ORCPT ); Wed, 16 Dec 2020 22:57:50 -0500 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E807DC0617A7; Wed, 16 Dec 2020 19:57:09 -0800 (PST) Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 8AEFA2C2; Thu, 17 Dec 2020 04:57:06 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1608177426; bh=CeiKeoDJuFXUx0AHENcynkDr6bZJyQ4HAeC/obSpibU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=RJZX2LfELR0TstaN5POWm7Al4x8ORmkoALPckEai0xH+I6J1Xnw7V+hZOlrRoN5qg pFQ7Sxkv++3blKSkKWGM33OpaeQsXpLDa0NDBfp+p4HRHXtrH+1oy43Hqs/hHnEYR2 DDqkNi8C8oy0VqhuHIwzyVpWcuE4c40+HipxLVww= Date: Thu, 17 Dec 2020 05:56:59 +0200 From: Laurent Pinchart To: Christophe JAILLET Cc: kieran.bingham+renesas@ideasonboard.com, mchehab@kernel.org, linux-media@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] media: vsp1: Fix an error handling path in the probe function Message-ID: References: <20201212174119.120027-1-christophe.jaillet@wanadoo.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20201212174119.120027-1-christophe.jaillet@wanadoo.fr> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Christophe, Thank you for the patch. On Sat, Dec 12, 2020 at 06:41:19PM +0100, Christophe JAILLET wrote: > A previous 'rcar_fcp_get()' call must be undone in the error handling path, > as already done in the remove function. > > Fixes: 94fcdf829793 ("[media] v4l: vsp1: Add FCP support") > Signed-off-by: Christophe JAILLET Reviewed-by: Laurent Pinchart and queued in my tree for v5.12. > --- > drivers/media/platform/vsp1/vsp1_drv.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/media/platform/vsp1/vsp1_drv.c b/drivers/media/platform/vsp1/vsp1_drv.c > index dc62533cf32c..aa66e4f5f3f3 100644 > --- a/drivers/media/platform/vsp1/vsp1_drv.c > +++ b/drivers/media/platform/vsp1/vsp1_drv.c > @@ -882,8 +882,10 @@ static int vsp1_probe(struct platform_device *pdev) > } > > done: > - if (ret) > + if (ret) { > pm_runtime_disable(&pdev->dev); > + rcar_fcp_put(vsp1->fcp); > + } > > return ret; > } -- Regards, Laurent Pinchart