From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08646C6FA8E for ; Fri, 24 Feb 2023 17:21:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229725AbjBXRVq (ORCPT ); Fri, 24 Feb 2023 12:21:46 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50702 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229454AbjBXRVo (ORCPT ); Fri, 24 Feb 2023 12:21:44 -0500 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 792AF158BF; Fri, 24 Feb 2023 09:21:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=hVqtr9A69/Si/EFagr+5HgP7SHagZOhLbSWzYrGADwQ=; b=LItUNW0Trf6fcGd6hJBbRaRstL stwDEmjolZnMfJzKOvSKW4DYjOQF4M9ihtyDTW+NSO9muiwINc+qKp872YxbNmSXZOtBbp1jPzWcB 0QKG0gY2bl8FGPKU3bXzncEox6oIacRQXz4OstV3ASwysT0lZYHGHauRQWVNETlwEvZKVwQEVJTrj fzp41hf3DDTpzvH0y2TMv7beyY2/99ZbK9lvVM5jc5aOZXZRfXoBvL1fk1d/rqM0aIy8ZoRYIt01f 7vIP7ZAsmkxsZ1+eqBnNo2w98KzuUK/F5XODOSBdoC36nrd4g4F21l6kJsjuhg/aT6loCGblVeZE6 9WFxINYQ==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1pVblM-003IPG-2u; Fri, 24 Feb 2023 17:21:40 +0000 Date: Fri, 24 Feb 2023 09:21:40 -0800 From: Luis Chamberlain To: Marc Zyngier Cc: Nick Alcock , linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org, Hitomi Hasegawa , Thomas Gleixner , Philipp Zabel Subject: Re: [PATCH 09/27] irqchip: remove MODULE_LICENSE in non-modules Message-ID: References: <20230224150811.80316-1-nick.alcock@oracle.com> <20230224150811.80316-10-nick.alcock@oracle.com> <86y1onw02k.wl-maz@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <86y1onw02k.wl-maz@kernel.org> Sender: Luis Chamberlain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 24, 2023 at 03:32:51PM +0000, Marc Zyngier wrote: > On Fri, 24 Feb 2023 15:07:53 +0000, > Nick Alcock wrote: > > > > Since commit 8b41fc4454e ("kbuild: create modules.builtin without > > Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations > > are used to identify modules. As a consequence, uses of the macro > > in non-modules will cause modprobe to misidentify their containing > > object file as a module when it is not (false positives), and modprobe > > might succeed rather than failing with a suitable error message. > > > > So remove it in the files in this commit, none of which can be built as > > modules. > > > > Signed-off-by: Nick Alcock > > Suggested-by: Luis Chamberlain > > Cc: Luis Chamberlain > > Cc: linux-modules@vger.kernel.org > > Cc: linux-kernel@vger.kernel.org > > Cc: Hitomi Hasegawa > > Cc: Thomas Gleixner > > Cc: Marc Zyngier > > Cc: Philipp Zabel > > --- > > drivers/irqchip/irq-renesas-rzg2l.c | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/drivers/irqchip/irq-renesas-rzg2l.c b/drivers/irqchip/irq-renesas-rzg2l.c > > index 25fd8ee66565..4bbfa2b0a4df 100644 > > --- a/drivers/irqchip/irq-renesas-rzg2l.c > > +++ b/drivers/irqchip/irq-renesas-rzg2l.c > > @@ -390,4 +390,3 @@ IRQCHIP_MATCH("renesas,rzg2l-irqc", rzg2l_irqc_init) > > IRQCHIP_PLATFORM_DRIVER_END(rzg2l_irqc) > > MODULE_AUTHOR("Lad Prabhakar "); > > MODULE_DESCRIPTION("Renesas RZ/G2L IRQC Driver"); > > -MODULE_LICENSE("GPL"); > > I'm probably missing some context here, but I find it odd to drop > something that is a important piece of information because of what > looks like a tooling regression. > > It also means that once a random driver gets enabled as a module, it > won't load because it is now missing a MODULE_LICENSE() annotation. > > It feels like MODULE_LICENSE should instead degrade to an empty > statement when MODULE isn't defined. Why isn't this approach the > correct one? > > I expect the cover letter would have some pretty good information on > this, but lore.kernel.org doesn't seem to have it at the time I write > this ("Message-ID <20230224150811.80316-1-nick.alcock@oracle.com> not > found"). The right thing is to not even have this and have the module license inferred from the SPDX tag. But for now we want to remove the tag from things we know for sure are not modules. Luis