From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Jiri Olsa <olsajiri@gmail.com>
Cc: Namhyung Kim <namhyung@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@kernel.org>, Ian Rogers <irogers@google.com>,
Adrian Hunter <adrian.hunter@intel.com>,
Andi Kleen <ak@linux.intel.com>,
Kan Liang <kan.liang@linux.intel.com>, Song Liu <song@kernel.org>,
Stephane Eranian <eranian@google.com>,
Ravi Bangoria <ravi.bangoria@amd.com>,
Leo Yan <leo.yan@linaro.org>, James Clark <james.clark@arm.com>,
Hao Luo <haoluo@google.com>, LKML <linux-kernel@vger.kernel.org>,
linux-perf-users@vger.kernel.org, bpf@vger.kernel.org
Subject: Re: [PATCH 4/7] perf record: Record dropped sample count
Date: Thu, 16 Feb 2023 13:32:14 -0300 [thread overview]
Message-ID: <Y+5ajnitOAxjdn2C@kernel.org> (raw)
In-Reply-To: <Y+5YaQt7Fme65a78@krava>
Em Thu, Feb 16, 2023 at 05:23:05PM +0100, Jiri Olsa escreveu:
> On Mon, Feb 13, 2023 at 09:04:49PM -0800, Namhyung Kim wrote:
>
> SNIP
>
> > @@ -1929,12 +1923,27 @@ static void record__read_lost_samples(struct record *rec)
> >
> > for (int x = 0; x < xyarray__max_x(xy); x++) {
> > for (int y = 0; y < xyarray__max_y(xy); y++) {
> > - __record__read_lost_samples(rec, evsel, lost, x, y);
> > + struct perf_counts_values count;
> > +
> > + if (perf_evsel__read(&evsel->core, x, y, &count) < 0) {
> > + pr_err("read LOST count failed\n");
> > + goto out;
> > + }
> > +
> > + if (count.lost) {
> > + __record__save_lost_samples(rec, evsel, lost,
> > + x, y, count.lost, 0);
> > + }
> > }
> > }
> > +
> > + lost_count = perf_bpf_filter__lost_count(evsel);
> > + if (lost_count)
> > + __record__save_lost_samples(rec, evsel, lost, 0, 0, lost_count,
> > + PERF_RECORD_MISC_LOST_SAMPLES_BPF);
>
> hi,
> I can't see PERF_RECORD_MISC_LOST_SAMPLES_BPF in the tip/perf/core so can't compile,
> what do I miss?
Humm, but you shouldn't need kernel headers to build tools/perf/, right?
- Arnaldo
next prev parent reply other threads:[~2023-02-16 16:32 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-14 5:04 [RFC/PATCHSET 0/7] perf record: Implement BPF sample filter (v1) Namhyung Kim
2023-02-14 5:04 ` [PATCH 1/7] perf bpf filter: Introduce basic BPF filter expression Namhyung Kim
2023-02-14 16:10 ` Ian Rogers
2023-02-14 18:03 ` Namhyung Kim
2023-02-14 5:04 ` [PATCH 2/7] perf bpf filter: Implement event sample filtering Namhyung Kim
2023-02-14 5:04 ` [PATCH 3/7] perf record: Add BPF event filter support Namhyung Kim
2023-02-14 5:04 ` [PATCH 4/7] perf record: Record dropped sample count Namhyung Kim
2023-02-14 16:40 ` Ian Rogers
2023-02-14 18:06 ` Namhyung Kim
2023-02-16 16:23 ` Jiri Olsa
2023-02-16 16:32 ` Arnaldo Carvalho de Melo [this message]
2023-02-16 16:34 ` Jiri Olsa
2023-02-16 18:38 ` Namhyung Kim
2023-02-14 5:04 ` [PATCH 5/7] perf bpf filter: Add 'pid' sample data support Namhyung Kim
2023-02-14 5:04 ` [PATCH 6/7] perf bpf filter: Add more weight " Namhyung Kim
2023-02-14 5:04 ` [PATCH 7/7] perf bpf filter: Add data_src " Namhyung Kim
2023-02-14 16:57 ` [RFC/PATCHSET 0/7] perf record: Implement BPF sample filter (v1) Ian Rogers
2023-02-14 18:01 ` Namhyung Kim
2023-02-21 11:54 ` Jiri Olsa
2023-02-22 19:42 ` Namhyung Kim
2023-02-14 19:16 ` Arnaldo Carvalho de Melo
2023-02-14 22:16 ` Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y+5ajnitOAxjdn2C@kernel.org \
--to=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=ak@linux.intel.com \
--cc=bpf@vger.kernel.org \
--cc=eranian@google.com \
--cc=haoluo@google.com \
--cc=irogers@google.com \
--cc=james.clark@arm.com \
--cc=kan.liang@linux.intel.com \
--cc=leo.yan@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=olsajiri@gmail.com \
--cc=peterz@infradead.org \
--cc=ravi.bangoria@amd.com \
--cc=song@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).