From: Greg KH <gregkh@linuxfoundation.org>
To: Zhou Furong <furong.zhou@linux.intel.com>
Cc: "Martin Zaťovič" <m.zatovic1@gmail.com>,
linux-kernel@vger.kernel.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, martin.petersen@oracle.com,
beanhuo@micron.com, arnd@arndb.de, avri.altman@wdc.com,
iwona.winiarska@intel.com, fmdefrancesco@gmail.com,
dipenp@nvidia.com, ogabbay@kernel.org, bvanassche@acm.org,
mathieu.poirier@linaro.org, yangyicong@hisilicon.com,
dan.j.williams@intel.com, devicetree@vger.kernel.org,
linus.walleij@linaro.org
Subject: Re: [PATCHv2 2/4] wiegand: add Wiegand bus driver
Date: Mon, 6 Feb 2023 11:26:16 +0100 [thread overview]
Message-ID: <Y+DVyPUXBliomobN@kroah.com> (raw)
In-Reply-To: <cd6bd118-68ef-1742-fd9d-08a65872b02c@linux.intel.com>
On Mon, Feb 06, 2023 at 05:49:44PM +0800, Zhou Furong wrote:
>
> > > +
> > > +#include <linux/device.h>
> > > +#include <linux/module.h>
> > > +#include <linux/of.h>
> > > +#include <linux/of_device.h>
> > > +#include <linux/slab.h>
> > > +#include <linux/wiegand.h>
> > > +#include <linux/dma-mapping.h>
> > > +#include <linux/dmaengine.h>
> > > +#include <linux/property.h>
> > > +
>
> please order headers
Why? What order? For what gain?
next prev parent reply other threads:[~2023-02-06 10:26 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-02 14:33 [PATCHv2 0/4] Wiegand bus driver and GPIO bit-banged controller Martin Zaťovič
2023-02-02 14:33 ` [PATCHv2 1/4] dt-bindings: wiegand: add Wiegand controller common properties Martin Zaťovič
2023-02-03 20:35 ` Rob Herring
2023-02-02 14:33 ` [PATCHv2 2/4] wiegand: add Wiegand bus driver Martin Zaťovič
2023-02-03 6:19 ` Greg KH
2023-02-06 9:49 ` Zhou Furong
2023-02-06 10:26 ` Greg KH [this message]
2023-02-07 0:36 ` Zhou Furong
2023-02-07 6:08 ` Greg KH
2023-02-07 12:59 ` Krzysztof Kozlowski
2023-02-03 22:42 ` kernel test robot
2023-02-02 14:33 ` [PATCHv2 3/4] dt-bindings: wiegand: add GPIO bitbanged Wiegand documentation Martin Zaťovič
2023-02-03 7:22 ` Krzysztof Kozlowski
2023-02-02 14:33 ` [PATCHv2 4/4] wiegand: add Wiegand GPIO bit-banged controller driver Martin Zaťovič
2023-02-02 20:39 ` kernel test robot
2023-02-03 6:20 ` Greg KH
2023-02-02 22:20 ` [PATCHv2 0/4] Wiegand bus driver and GPIO bit-banged controller Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y+DVyPUXBliomobN@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=arnd@arndb.de \
--cc=avri.altman@wdc.com \
--cc=beanhuo@micron.com \
--cc=bvanassche@acm.org \
--cc=dan.j.williams@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=dipenp@nvidia.com \
--cc=fmdefrancesco@gmail.com \
--cc=furong.zhou@linux.intel.com \
--cc=iwona.winiarska@intel.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m.zatovic1@gmail.com \
--cc=martin.petersen@oracle.com \
--cc=mathieu.poirier@linaro.org \
--cc=ogabbay@kernel.org \
--cc=robh+dt@kernel.org \
--cc=yangyicong@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).